fixes for R CMD check; ensure subplot populates a legend

Author: cpsievert

R/subplots.R

@@ -40,13 +40,13 @@
 #' economics_long %>%
 #'   split(.$variable) %>%
 #'   map(~ plot_ly(., x = ~date, y = ~value)) %>%
-#'   subplot(nrows = NROW(.), shareX = T)
+#'   subplot(nrows = NROW(.), shareX = TRUE)
 #'   
 #' # or pass a tibble with a list-column of plotly objects
 #' economics_long %>%
 #'   group_by(variable) %>%
 #'   do(p = plot_ly(., x = ~date, y = ~value)) %>%
-#'   subplot(nrows = NROW(.), shareX = T)
+#'   subplot(nrows = NROW(.), shareX = TRUE)
 #'   
 #' # learn more at https://cpsievert.github.io/plotly_book/subplot.html
 #' 

man/subplot.Rd

@@ -45,10 +45,13 @@ test_that("group + [x/y]axis works", {
   expect_true(all(1 >= xdom[[3]] & xdom[[3]] > 2/3))
 })
 
-test_that("shareX produces one x-axis", {
+test_that("shareX produces one x-axis and a legend", {
   s <- subplot(plot_ly(x = 1), plot_ly(x = 1), nrows = 2, shareX = TRUE)
   l <- expect_traces(s, 2, "shareX")
   expect_true(sum(grepl("^xaxis", names(l$layout))) == 1)
+  expect_true(l$data[[1]]$showlegend %||% TRUE)
+  expect_true(l$data[[2]]$showlegend %||% TRUE)
+  expect_true(l$layout$showlegend %||% TRUE)
 })
 
 test_that("shareY produces one y-axis", {