Skip to content

Commit a978fbc

Browse files
committed
Merge branch 'master' of github.com:ropensci/plotly into fix/subplot
2 parents f342c0b + bc28595 commit a978fbc

File tree

3 files changed

+19
-3
lines changed

3 files changed

+19
-3
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: plotly
22
Title: Create Interactive Web Graphics via 'plotly.js'
3-
Version: 3.5.5
3+
Version: 3.5.7
44
Authors@R: c(person("Carson", "Sievert", role = c("aut", "cre"),
55
email = "[email protected]"),
66
person("Chris", "Parmer", role = c("aut", "cph"),

NEWS

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,19 @@
1+
3.5.7 -- 13 May 2016
2+
3+
CHANGES:
4+
5+
Better defaults for defaultWidth/defaultHeight in the htmlwidget's sizing policy.
6+
7+
BUG FIX:
8+
9+
Pass knitr options to the named argument options. Fixes #582.
10+
11+
3.5.6 -- 12 May 2016
12+
13+
BUG FIX:
14+
15+
Use .embed suffix in iframe src attribute. Fixes #581.
16+
117
3.5.5 -- 5 May 2016
218

319
CHANGES:

R/print.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ print.plotly_built <- print.plotly_hash
2323
#' @export
2424
knit_print.plotly_hash <- function(x, options, ...) {
2525
x <- as.widget(x)
26-
knitr::knit_print(x, options, ...)
26+
knitr::knit_print(x, options = options, ...)
2727
}
2828

2929
#' Print a 'built' plotly object in a knitr doc
@@ -135,7 +135,7 @@ embed_notebook <- function(x, width = NULL, height = NULL,
135135

136136
plotly_iframe <- function(url = "", width = NULL, height = NULL) {
137137
sprintf(
138-
'<iframe src="%s" width="%s" height="%s" id="igraph" scrolling="no" seamless="seamless" frameBorder="0"> </iframe>',
138+
'<iframe src="%s.embed" width="%s" height="%s" id="igraph" scrolling="no" seamless="seamless" frameBorder="0"> </iframe>',
139139
url, width %||% "100%", height %||% "400"
140140
)
141141
}

0 commit comments

Comments
 (0)