Add isosurface to non-tidy traces

cpsievert · cpsievert · commit e690ae9fd543 · 2019-04-02T13:34:20.000-05:00
diff --git a/R/utils.R b/R/utils.R
@@ -102,10 +102,11 @@ getLevels <- function(x) {
 tryNULL <- function(expr) tryCatch(expr, error = function(e) NULL)
 
 # Don't attempt to do "tidy" data training on these trace types
+# Note that non-tidy traces expect/anticipate data_array's of varying lengths
 is_tidy <- function(trace) {
   type <- trace[["type"]] %||% "scatter"
   !type %in% c(
-    "mesh3d", "heatmap", "histogram2d", 
+    "mesh3d", "heatmap", "histogram2d", "isosurface",
     "histogram2dcontour", "contour", "surface"
   )
 }

Original file line number	Diff line number	Diff line change
`@@ -102,10 +102,11 @@ getLevels <- function(x) {`
`102`	`102`	`tryNULL <- function(expr) tryCatch(expr, error = function(e) NULL)`
`103`	`103`
`104`	`104`	`# Don't attempt to do "tidy" data training on these trace types`
	`105`	`+# Note that non-tidy traces expect/anticipate data_array's of varying lengths`
`105`	`106`	`is_tidy <- function(trace) {`
`106`	`107`	`type <- trace[["type"]] %\|\|% "scatter"`
`107`	`108`	`!type %in% c(`
`108`		`- "mesh3d", "heatmap", "histogram2d",`
	`109`	`+ "mesh3d", "heatmap", "histogram2d", "isosurface",`
`109`	`110`	`"histogram2dcontour", "contour", "surface"`
`110`	`111`	`)`
`111`	`112`	`}`