add a comment

cpsievert · cpsievert · commit fed201743109 · 2019-04-03T10:57:24.000-05:00
diff --git a/R/utils.R b/R/utils.R
@@ -488,6 +488,8 @@ verify_attr <- function(proposed, schema, layoutAttr = FALSE) {
     }
     
     # tag 'src-able' attributes (needed for api_create())
+    # note that layout has 'src-able' attributes that shouldn't
+    # be turned into grids https://github.com/ropensci/plotly/pull/1489
     isSrcAble <- !is.null(schema[[paste0(attr, "src")]]) && length(proposed[[attr]]) > 1
     if ((isDataArray || isSrcAble) && !isTRUE(layoutAttr)) {
       proposed[[attr]] <- structure(proposed[[attr]], apiSrc = TRUE)

Original file line number	Diff line number	Diff line change
`@@ -488,6 +488,8 @@ verify_attr <- function(proposed, schema, layoutAttr = FALSE) {`
`488`	`488`	`}`
`489`	`489`
`490`	`490`	`# tag 'src-able' attributes (needed for api_create())`
	`491`	`+ # note that layout has 'src-able' attributes that shouldn't`
	`492`	`+ # be turned into grids https://github.com/ropensci/plotly/pull/1489`
`491`	`493`	`isSrcAble <- !is.null(schema[[paste0(attr, "src")]]) && length(proposed[[attr]]) > 1`
`492`	`494`	`if ((isDataArray \|\| isSrcAble) && !isTRUE(layoutAttr)) {`
`493`	`495`	`proposed[[attr]] <- structure(proposed[[attr]], apiSrc = TRUE)`