Skip to content

Commit 074a5f8

Browse files
committed
drop deprecated attribute 'gl3d.cameraposition' (use 'gl3d.camera' instead)
1 parent d5d3712 commit 074a5f8

File tree

2 files changed

+0
-31
lines changed

2 files changed

+0
-31
lines changed

src/plot_api/helpers.js

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -108,29 +108,6 @@ exports.cleanLayout = function(layout) {
108108

109109
var scene = layout[key];
110110

111-
// clean old Camera coords
112-
var cameraposition = scene.cameraposition;
113-
114-
if(Array.isArray(cameraposition) && cameraposition[0].length === 4) {
115-
var rotation = cameraposition[0];
116-
var center = cameraposition[1];
117-
var radius = cameraposition[2];
118-
var mat = m4FromQuat([], rotation);
119-
var eye = [];
120-
121-
for(j = 0; j < 3; ++j) {
122-
eye[j] = center[j] + radius * mat[2 + 4 * j];
123-
}
124-
125-
scene.camera = {
126-
eye: {x: eye[0], y: eye[1], z: eye[2]},
127-
center: {x: center[0], y: center[1], z: center[2]},
128-
up: {x: 0, y: 0, z: 1} // we just ignore calculating camera z up in this case
129-
};
130-
131-
delete scene.cameraposition;
132-
}
133-
134111
// clean axis titles
135112
cleanTitle(scene.xaxis);
136113
cleanTitle(scene.yaxis);

src/plots/gl3d/layout/layout_attributes.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -159,12 +159,4 @@ module.exports = {
159159
].join(' ')
160160
},
161161
editType: 'plot',
162-
163-
_deprecated: {
164-
cameraposition: {
165-
valType: 'info_array',
166-
editType: 'camera',
167-
description: 'Obsolete. Use `camera` instead.'
168-
}
169-
}
170162
};

0 commit comments

Comments
 (0)