Skip to content

Commit 0979272

Browse files
committed
clean splom drag logic
1 parent 468119e commit 0979272

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

src/traces/splom/base_plot.js

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,9 @@ function drag(gd) {
4242
var trace = cd0.trace;
4343
var scene = cd0.t._scene;
4444

45-
// FIXME: this probably should not be called for non-splom traces
46-
if(!scene || !scene.matrixOptions) continue;
47-
48-
var opts = scene.matrixOptions;
49-
5045
if(trace.type === 'splom' && scene && scene.matrix) {
5146
var activeLength = trace._activeLength;
52-
var visibleLength = opts.data.length;
47+
var visibleLength = scene.matrixOptions.data.length;
5348
var ranges = new Array(visibleLength);
5449
var k = 0;
5550

@@ -67,7 +62,7 @@ function drag(gd) {
6762
}
6863

6964
if(fullLayout._hasOnlyLargeSploms) {
70-
fullLayout._modules[0].basePlotModule.drawGrid(gd);
65+
drawGrid(gd);
7166
}
7267
}
7368

@@ -228,7 +223,7 @@ module.exports = {
228223
drawFramework: Cartesian.drawFramework,
229224
plot: plot,
230225
drag: drag,
231-
drawGrid: drawGrid,
232226
clean: clean,
227+
updateFx: Cartesian.updateFx,
233228
toSVG: Cartesian.toSVG
234229
};

0 commit comments

Comments
 (0)