Skip to content

Commit 0ad1a0c

Browse files
committed
preparing for user-specified stroke/stroke-opacity, fill/fill-opacity setting via Drawing.*
1 parent cd0578d commit 0ad1a0c

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/traces/table/plot.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -215,9 +215,7 @@ module.exports = function plot(gd, wrappedTraceHolders) {
215215
columnBoundaryRect.enter()
216216
.append('rect')
217217
.classed('columnBoundaryRect', true)
218-
.attr('fill', 'none')
219-
.attr('stroke', 'magenta')
220-
.attr('stroke-width', 2);
218+
.attr('fill', 'none');
221219

222220
columnBoundaryRect
223221
.attr('width', function(d) {return d.columnWidth;})
@@ -325,7 +323,8 @@ function renderScrollbarKit(tableControlView, gd) {
325323
scrollbarCaptureZone.enter()
326324
.append('line')
327325
.classed('scrollbarCaptureZone', true)
328-
.attr('stroke', 'rgba(0,0,0,0.01)')
326+
.attr('stroke', 'white')
327+
.attr('stroke-opacity', 0.01) // some browser might get rid of a 0 opacity element
329328
.attr('stroke-width', c.scrollbarCaptureWidth)
330329
.attr('stroke-linecap', 'butt')
331330
.attr('y1', 0)
@@ -482,7 +481,7 @@ function sizeAndStyleRect(cellRect) {
482481
return gridPick(d.calcdata.cells.line.color, d.column.specIndex, d.rowNumber);
483482
})
484483
.attr('fill', function(d) {
485-
return d.calcdata.cells.fill ? gridPick(d.calcdata.cells.fill.color, d.column.specIndex, d.rowNumber) : 'none';
484+
return gridPick(d.calcdata.cells.fill.color, d.column.specIndex, d.rowNumber);
486485
});
487486
}
488487

0 commit comments

Comments
 (0)