Skip to content

Commit 1325b7c

Browse files
committed
only coerce label properties if label text is given
1 parent 394b48f commit 1325b7c

File tree

2 files changed

+18
-15
lines changed

2 files changed

+18
-15
lines changed

src/components/shapes/defaults.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -135,12 +135,13 @@ function handleShapeDefaults(shapeIn, shapeOut, fullLayout) {
135135

136136
// Label options
137137
var isLine = shapeType === 'line';
138-
coerce('label.text');
139-
coerce('label.textangle', isLine ? 'auto' : 0);
140-
var labelTextPosition = coerce('label.textposition', isLine ? 'middle' : 'middle center');
141-
coerce('label.xanchor');
142-
// Default yanchor value depends on shape type and label textposition
143-
coerce('label.yanchor', dfltLabelYanchor(isLine, labelTextPosition));
144-
coerce('label.padding');
145-
Lib.coerceFont(coerce, 'label.font', fullLayout.font);
138+
var labelText = coerce('label.text');
139+
if(labelText) {
140+
coerce('label.textangle', isLine ? 'auto' : 0);
141+
var labelTextPosition = coerce('label.textposition', isLine ? 'middle' : 'middle center');
142+
coerce('label.xanchor');
143+
coerce('label.yanchor', dfltLabelYanchor(isLine, labelTextPosition));
144+
coerce('label.padding');
145+
Lib.coerceFont(coerce, 'label.font', fullLayout.font);
146+
}
146147
}

src/components/shapes/draw_newshape/defaults.js

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,15 @@ module.exports = function supplyDrawNewShapeDefaults(layoutIn, layoutOut, coerce
3434
}
3535

3636
var isLine = layoutIn.dragmode === 'drawline';
37-
coerce('newshape.label.text');
38-
coerce('newshape.label.textangle', isLine ? 'auto' : 0);
39-
var labelTextPosition = coerce('newshape.label.textposition', isLine ? 'middle' : 'middle center');
40-
coerce('newshape.label.xanchor');
41-
coerce('newshape.label.yanchor', dfltLabelYanchor(isLine, labelTextPosition));
42-
coerce('newshape.label.padding');
43-
Lib.coerceFont(coerce, 'newshape.label.font', layoutOut.font);
37+
var labelText = coerce('newshape.label.text');
38+
if(labelText) {
39+
coerce('newshape.label.textangle', isLine ? 'auto' : 0);
40+
var labelTextPosition = coerce('newshape.label.textposition', isLine ? 'middle' : 'middle center');
41+
coerce('newshape.label.xanchor');
42+
coerce('newshape.label.yanchor', dfltLabelYanchor(isLine, labelTextPosition));
43+
coerce('newshape.label.padding');
44+
Lib.coerceFont(coerce, 'newshape.label.font', layoutOut.font);
45+
}
4446

4547
coerce('activeshape.fillcolor');
4648
coerce('activeshape.opacity');

0 commit comments

Comments
 (0)