Skip to content

Commit 21b59e4

Browse files
committed
fixups u and v
1 parent 6e80dc9 commit 21b59e4

File tree

6 files changed

+15
-13
lines changed

6 files changed

+15
-13
lines changed

src/plots/cartesian/axes.js

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ var CAP_SHIFT = alignmentConstants.CAP_SHIFT;
4848
var LINE_SPACING = alignmentConstants.LINE_SPACING;
4949
var OPPOSITE_SIDE = alignmentConstants.OPPOSITE_SIDE;
5050

51+
var TEXTPAD = 3;
52+
5153
var axes = module.exports = {};
5254

5355
axes.setConvert = require('./set_convert');
@@ -2518,21 +2520,21 @@ function getTickLabelUV(ax) {
25182520
if(!isAligned && !isInside) return [0, 0];
25192521

25202522
var side = ax.side;
2521-
var isX = ax._id.charAt(0) === 'x';
25222523

2523-
var dx = (ax.tickwidth || 0) / 2;
2524-
var dy = (ax.linewidth || 0) / 2;
2525-
var u = isX ? dx : dy;
2526-
var v = isX ? dy : dx;
2524+
var u = isAligned ? (ax.tickwidth || 0) / 2 : 0;
2525+
var v = (ax.linewidth || 0) / 2 + TEXTPAD;
25272526

25282527
var fontSize = ax.tickfont ? ax.tickfont.size : 12;
2529-
if(isX) {
2530-
u += 3; // add extra pad
2531-
} else {
2532-
v += 3; // add extra pad
2533-
2534-
if(isAligned) {
2535-
u += fontSize * CAP_SHIFT;
2528+
if(isBottom || isTop) {
2529+
u += fontSize * CAP_SHIFT;
2530+
}
2531+
if(isLeft || isRight) {
2532+
u += TEXTPAD;
2533+
}
2534+
if(isInside) {
2535+
if(side === 'top') {
2536+
v -= fontSize * MID_SHIFT;
2537+
v += TEXTPAD;
25362538
}
25372539
}
25382540

@@ -3111,7 +3113,7 @@ axes.drawLabels = function(gd, ax, opts) {
31113113
var isBottom = has('bottom');
31123114
var isAligned = isBottom || isLeft || isTop || isRight;
31133115
var pad = !isAligned ? 0 :
3114-
(ax.tickwidth || 0) + 2 * 3; // extra pad
3116+
(ax.tickwidth || 0) + 2 * TEXTPAD;
31153117

31163118
var rotate90 = (tickSpacing < maxFontSize * 2.5) || ax.type === 'multicategory';
31173119

-225 Bytes
Loading
-225 Bytes
Loading
-138 Bytes
Loading
85 Bytes
Loading
-26 Bytes
Loading

0 commit comments

Comments
 (0)