generalize setPositions for barpolar

Author: etpinard

src/plot_api/plot_api.js

@@ -329,9 +329,13 @@ exports.plot = function(gd, data, layout, config) {
         marginPushers,
         marginPushersAgain
     ];
+
     if(hasCartesian) seq.push(positionAndAutorange);
+    else seq.push(Plots.doSetPositions);
+
     seq.push(subroutines.layoutStyles);
     if(hasCartesian) seq.push(drawAxes);
+
     seq.push(
         subroutines.drawData,
         subroutines.finalDraw,

src/plots/plots.js

@@ -2566,24 +2566,40 @@ function clearAxesCalc(axList) {
 
 plots.doSetPositions = function(gd) {
     var fullLayout = gd._fullLayout;
-    var subplots = fullLayout._subplots.cartesian;
     var modules = fullLayout._visibleModules;
-    var methods = [];
-    var i, j;
+    var hash = {};
+    var i, j, k;
 
     // position and range calculations for traces that
     // depend on each other ie bars (stacked or grouped)
     // and boxes (grouped) push each other out of the way
 
     for(j = 0; j < modules.length; j++) {
-        Lib.pushUnique(methods, modules[j].setPositions);
+        var _module = modules[j];
+        var fn = _module.setPositions;
+        if(fn) {
+            var spType = _module.basePlotModule.name;
+            if(hash[spType]) {
+                Lib.pushUnique(hash[spType], fn);
+            } else {
+                hash[spType] = [fn];
+            }
+        }
     }
-    if(!methods.length) return;
 
-    for(i = 0; i < subplots.length; i++) {
-        var subplotInfo = fullLayout._plots[subplots[i]];
-        for(j = 0; j < methods.length; j++) {
-            methods[j](gd, subplotInfo);
+    for(k in hash) {
+        var methods = hash[k];
+        var subplots = fullLayout._subplots[k];
+
+        for(i = 0; i < subplots.length; i++) {
+            var sp = subplots[i];
+            var spInfo = k === 'cartesian' ?
+                fullLayout._plots[sp] :
+                fullLayout[sp];
+
+            for(j = 0; j < methods.length; j++) {
+                methods[j](gd, spInfo);
+            }
         }
     }
 };