enforce key-spacing

Author: etpinard

.eslintrc

@@ -19,7 +19,7 @@
     "comma-style": [2, "last"],
     "semi": [2],
     "semi-spacing": [2, {"before": false, "after": true}],
-    "key-spacing": [0, {"beforeColon": false, "afterColon": true}],
+    "key-spacing": [2, {"beforeColon": false, "afterColon": true}],
     "no-spaced-func": [2],
     "space-in-parens": [2, "never"],
     "space-before-function-paren": [2, "never"],

src/components/annotations/index.js

@@ -572,7 +572,7 @@ annotations.draw = function(gd, index, opt, value) {
                 .attr({
                     'data-index': String(index),
                     d: 'M3,3H-3V-3H3ZM0,0L' + (arrowX0-arrowX) + ',' + (arrowY0-arrowY),
-                    transform:'translate('+arrowX+','+arrowY+')'
+                    transform: 'translate('+arrowX+','+arrowY+')'
                 })
                 .style('stroke-width', (strokewidth+6)+'px')
                 .call(Plotly.Color.stroke, 'rgba(0,0,0,0)')

src/components/color/index.js

@@ -45,14 +45,14 @@ color.combine = function(front, back){
 
     var bc = tinycolor(back||color.background).toRgb(),
         bcflat = bc.a===1 ? bc : {
-            r:255*(1-bc.a) + bc.r*bc.a,
-            g:255*(1-bc.a) + bc.g*bc.a,
-            b:255*(1-bc.a) + bc.b*bc.a
+            r: 255 * (1-bc.a) + bc.r*bc.a,
+            g: 255 * (1-bc.a) + bc.g*bc.a,
+            b: 255 * (1-bc.a) + bc.b*bc.a
         },
         fcflat = {
-            r:bcflat.r*(1-fc.a) + fc.r*fc.a,
-            g:bcflat.g*(1-fc.a) + fc.g*fc.a,
-            b:bcflat.b*(1-fc.a) + fc.b*fc.a
+            r: bcflat.r*(1-fc.a) + fc.r*fc.a,
+            g: bcflat.g*(1-fc.a) + fc.g*fc.a,
+            b: bcflat.b*(1-fc.a) + fc.b*fc.a
         };
     return tinycolor(fcflat).toRgbString();
 };

src/components/colorbar/draw.js

@@ -132,7 +132,7 @@ module.exports = function draw(gd, id) {
 
             // y positioning we can do correctly from the start
             yBottomFrac = opts.y + lenFrac *
-                (({top:-0.5, bottom:0.5}[opts.yanchor]||0)-0.5),
+                (({top: -0.5, bottom: 0.5}[opts.yanchor] || 0) - 0.5),
             yBottomPx = Math.round(fullLayout._size.h * (1-yBottomFrac)),
             yTopPx = yBottomPx-lenPx,
             titleEl,
@@ -431,7 +431,7 @@ module.exports = function draw(gd, id) {
             });
 
             // fix positioning for xanchor!='left'
-            var xoffset = ({center:0.5, right:1}[opts.xanchor]||0) *
+            var xoffset = ({center: 0.5, right: 1}[opts.xanchor] || 0) *
                 outerwidth;
             container.attr('transform',
                 'translate('+(fullLayout._size.l-xoffset)+','+fullLayout._size.t+')');
@@ -440,10 +440,10 @@ module.exports = function draw(gd, id) {
             Plots.autoMargin(gd, id,{
                 x: opts.x,
                 y: opts.y,
-                l: outerwidth*({right:1, center:0.5}[opts.xanchor]||0),
-                r: outerwidth*({left:1, center:0.5}[opts.xanchor]||0),
-                t: outerheight*({bottom:1, middle:0.5}[opts.yanchor]||0),
-                b: outerheight*({top:1, middle:0.5}[opts.yanchor]||0)
+                l: outerwidth * ({right: 1, center: 0.5}[opts.xanchor] || 0),
+                r: outerwidth * ({left: 1, center: 0.5}[opts.xanchor] || 0),
+                t: outerheight * ({bottom: 1, middle: 0.5}[opts.yanchor] || 0),
+                b: outerheight * ({top: 1, middle: 0.5}[opts.yanchor] || 0)
             });
         }
 

src/components/colorscale/scales.js

@@ -10,31 +10,31 @@
 
 
 module.exports = {
-    'Greys':[[0,'rgb(0,0,0)'],[1,'rgb(255,255,255)']],
+    'Greys': [[0,'rgb(0,0,0)'],[1,'rgb(255,255,255)']],
 
-    'YIGnBu':[[0,'rgb(8, 29, 88)'],[0.125,'rgb(37, 52, 148)'],
+    'YIGnBu': [[0,'rgb(8, 29, 88)'],[0.125,'rgb(37, 52, 148)'],
         [0.25,'rgb(34, 94, 168)'],[0.375,'rgb(29, 145, 192)'],
         [0.5,'rgb(65, 182, 196)'],[0.625,'rgb(127, 205, 187)'],
         [0.75,'rgb(199, 233, 180)'],[0.875,'rgb(237, 248, 217)'],
         [1,'rgb(255, 255, 217)']],
 
-    'Greens':[[0,'rgb(0, 68, 27)'],[0.125,'rgb(0, 109, 44)'],
+    'Greens': [[0,'rgb(0, 68, 27)'],[0.125,'rgb(0, 109, 44)'],
         [0.25,'rgb(35, 139, 69)'],[0.375,'rgb(65, 171, 93)'],
         [0.5,'rgb(116, 196, 118)'],[0.625,'rgb(161, 217, 155)'],
         [0.75,'rgb(199, 233, 192)'],[0.875,'rgb(229, 245, 224)'],
         [1,'rgb(247, 252, 245)']],
 
-    'YIOrRd':[[0,'rgb(128, 0, 38)'],[0.125,'rgb(189, 0, 38)'],
+    'YIOrRd': [[0,'rgb(128, 0, 38)'],[0.125,'rgb(189, 0, 38)'],
         [0.25,'rgb(227, 26, 28)'],[0.375,'rgb(252, 78, 42)'],
         [0.5,'rgb(253, 141, 60)'],[0.625,'rgb(254, 178, 76)'],
         [0.75,'rgb(254, 217, 118)'],[0.875,'rgb(255, 237, 160)'],
         [1,'rgb(255, 255, 204)']],
 
-    'Bluered':[[0,'rgb(0,0,255)'],[1,'rgb(255,0,0)']],
+    'Bluered': [[0,'rgb(0,0,255)'],[1,'rgb(255,0,0)']],
 
     // modified RdBu based on
     // www.sandia.gov/~kmorel/documents/ColorMaps/ColorMapsExpanded.pdf
-    'RdBu':[[0,'rgb(5, 10, 172)'],[0.35,'rgb(106, 137, 247)'],
+    'RdBu': [[0,'rgb(5, 10, 172)'],[0.35,'rgb(106, 137, 247)'],
         [0.5,'rgb(190,190,190)'],[0.6,'rgb(220, 170, 132)'],
         [0.7,'rgb(230, 145, 90)'],[1,'rgb(178, 10, 28)']],
     // Scale for non-negative numeric values
@@ -45,39 +45,39 @@ module.exports = {
         [0.5, 'rgb(70, 100, 245)'], [0.6, 'rgb(90, 120, 245)'],
         [0.7, 'rgb(106, 137, 247)'], [1, 'rgb(220, 220, 220)']],
 
-    'Picnic':[[0,'rgb(0,0,255)'],[0.1,'rgb(51,153,255)'],
+    'Picnic': [[0,'rgb(0,0,255)'],[0.1,'rgb(51,153,255)'],
         [0.2,'rgb(102,204,255)'],[0.3,'rgb(153,204,255)'],
         [0.4,'rgb(204,204,255)'],[0.5,'rgb(255,255,255)'],
         [0.6,'rgb(255,204,255)'],[0.7,'rgb(255,153,255)'],
         [0.8,'rgb(255,102,204)'],[0.9,'rgb(255,102,102)'],
         [1,'rgb(255,0,0)']],
 
-    'Rainbow':[[0,'rgb(150,0,90)'],[0.125,'rgb(0, 0, 200)'],
+    'Rainbow': [[0,'rgb(150,0,90)'],[0.125,'rgb(0, 0, 200)'],
         [0.25,'rgb(0, 25, 255)'],[0.375,'rgb(0, 152, 255)'],
         [0.5,'rgb(44, 255, 150)'],[0.625,'rgb(151, 255, 0)'],
         [0.75,'rgb(255, 234, 0)'],[0.875,'rgb(255, 111, 0)'],
         [1,'rgb(255, 0, 0)']],
 
-    'Portland':[[0,'rgb(12,51,131)'],[0.25,'rgb(10,136,186)'],
+    'Portland': [[0,'rgb(12,51,131)'],[0.25,'rgb(10,136,186)'],
         [0.5,'rgb(242,211,56)'],[0.75,'rgb(242,143,56)'],
         [1,'rgb(217,30,30)']],
 
-    'Jet':[[0,'rgb(0,0,131)'],[0.125,'rgb(0,60,170)'],
+    'Jet': [[0,'rgb(0,0,131)'],[0.125,'rgb(0,60,170)'],
         [0.375,'rgb(5,255,255)'],[0.625,'rgb(255,255,0)'],
         [0.875,'rgb(250,0,0)'],[1,'rgb(128,0,0)']],
 
-    'Hot':[[0,'rgb(0,0,0)'],[0.3,'rgb(230,0,0)'],
+    'Hot': [[0,'rgb(0,0,0)'],[0.3,'rgb(230,0,0)'],
         [0.6,'rgb(255,210,0)'],[1,'rgb(255,255,255)']],
 
-    'Blackbody':[[0,'rgb(0,0,0)'],[0.2,'rgb(230,0,0)'],
+    'Blackbody': [[0,'rgb(0,0,0)'],[0.2,'rgb(230,0,0)'],
         [0.4,'rgb(230,210,0)'],[0.7,'rgb(255,255,255)'],
         [1,'rgb(160,200,255)']],
 
-    'Earth':[[0,'rgb(0,0,130)'],[0.1,'rgb(0,180,180)'],
+    'Earth': [[0,'rgb(0,0,130)'],[0.1,'rgb(0,180,180)'],
         [0.2,'rgb(40,210,40)'],[0.4,'rgb(230,230,50)'],
         [0.6,'rgb(120,70,20)'],[1,'rgb(255,255,255)']],
 
-    'Electric':[[0,'rgb(0,0,0)'],[0.15,'rgb(30,0,100)'],
+    'Electric': [[0,'rgb(0,0,0)'],[0.15,'rgb(30,0,100)'],
         [0.4,'rgb(120,0,100)'],[0.6,'rgb(160,90,0)'],
         [0.8,'rgb(230,200,0)'],[1,'rgb(255,250,220)']],
 

src/components/drawing/index.js

@@ -296,7 +296,7 @@ drawing.tryColorscale = function(cont, contIn, prefix) {
 };
 
 // draw text at points
-var TEXTOFFSETSIGN = {start:1, end:-1, middle:0, bottom:1, top:-1},
+var TEXTOFFSETSIGN = {start: 1, end: -1, middle: 0, bottom: 1, top: -1},
     LINEEXPAND = 1.3;
 drawing.textPointStyle = function(s, trace) {
     s.each(function(d){
@@ -467,7 +467,10 @@ drawing.makeTester = function(gd) {
     testref.enter().append('path')
         .classed('js-reference-point', true)
         .attr('d','M0,0H1V1H0Z')
-        .style({'stroke-width':0, fill:'black'});
+        .style({
+            'stroke-width': 0,
+            fill: 'black'
+        });
 
     if(!tester.node()._cache) {
         tester.node()._cache = {};
@@ -498,7 +501,11 @@ drawing.bBox = function(node) {
     var testNode = node.cloneNode(true);
     tester.appendChild(testNode);
     // standardize its position... do we really want to do this?
-    d3.select(testNode).attr({x:0, y:0, transform:''});
+    d3.select(testNode).attr({
+        x: 0,
+        y: 0,
+        transform: ''
+    });
 
     var testRect = testNode.getBoundingClientRect(),
         refRect = test3.select('.js-reference-point')

src/components/titles/index.js

@@ -59,8 +59,8 @@ Titles.draw = function(gd, title) {
         xa,
         ya,
         avoid = {
-            selection:d3.select(gd).selectAll('g.'+cont._id+'tick'),
-            side:cont.side
+            selection: d3.select(gd).selectAll('g.'+cont._id+'tick'),
+            side: cont.side
         },
         // multiples of fontsize to offset label from axis
         offsetBase = colorbar ? 0 : 1.5,

src/lib/dates.js

@@ -166,22 +166,22 @@ exports.ms2DateTime = function(ms, r) {
 // TODO: this is way out of date vs. the server-side version
 var timeFormats = {
     // 24 hour
-    H:['%H:%M:%S~%L', '%H:%M:%S', '%H:%M'],
+    H: ['%H:%M:%S~%L', '%H:%M:%S', '%H:%M'],
     // with am/pm
-    I:['%I:%M:%S~%L%p', '%I:%M:%S%p', '%I:%M%p'],
+    I: ['%I:%M:%S~%L%p', '%I:%M:%S%p', '%I:%M%p'],
     // no colon, ie only date or date with hour (could also support eg 12h34m?)
-    D:['%H', '%I%p', '%Hh']
+    D: ['%H', '%I%p', '%Hh']
 };
 
 var dateFormats = {
-    Y:[
+    Y: [
         '%Y~%m~%d',
         '%Y%m%d',
         '%y%m%d', // YYMMDD, has 6 digits together so will match Y, not y
         '%m~%d~%Y', // MM/DD/YYYY has first precedence
         '%d~%m~%Y' // then DD/MM/YYYY
     ],
-    Yb:[
+    Yb: [
         '%b~%d~%Y', // eg nov 21 2013
         '%d~%b~%Y', // eg 21 nov 2013
         '%Y~%d~%b', // eg 2013 21 nov (or 2013 q3, after replacement)
@@ -191,12 +191,12 @@ var dateFormats = {
      * the two-digit year cases have so many potential ambiguities
      * it's not even funny, but we'll try them anyway.
      */
-    y:[
+    y: [
         '%m~%d~%y',
         '%d~%m~%y',
         '%y~%m~%d'
     ],
-    yb:[
+    yb: [
         '%b~%d~%y',
         '%d~%b~%y',
         '%y~%d~%b',

src/lib/svg_text_utils.js

@@ -149,7 +149,7 @@ util.convertToTspans = function(_context, _callback){
                 var newSvgW = getSize(newSvg, 'width'),
                     newSvgH = getSize(newSvg, 'height'),
                     newX = +that.attr('x') - newSvgW *
-                        {start:0, middle:0.5, end:1}[that.attr('text-anchor') || 'start'],
+                        {start: 0, middle: 0.5, end: 1}[that.attr('text-anchor') || 'start'],
                     // font baseline is about 1/4 fontSize below centerline
                     textHeight = parseInt(that.style('font-size'), 10) ||
                         getSize(that, 'height'),

src/plot_api/plot_api.js

@@ -1831,7 +1831,7 @@ Plotly.restyle = function restyle(gd, astr, val, traces) {
                 // it flips everything and the axes
                 else if(ai==='orientationaxes') {
                     cont.orientation =
-                        {v:'h', h:'v'}[contFull.orientation];
+                        {v: 'h', h: 'v'}[contFull.orientation];
                 }
                 swapXYData(cont);
             }