Skip to content

Commit 304e214

Browse files
committed
centralize heatmap label defaults
1 parent e8f3287 commit 304e214

File tree

5 files changed

+19
-19
lines changed

5 files changed

+19
-19
lines changed

src/traces/contour/defaults.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ var handlePeriodDefaults = require('../scatter/period_defaults');
77
var handleConstraintDefaults = require('./constraint_defaults');
88
var handleContoursDefaults = require('./contours_defaults');
99
var handleStyleDefaults = require('./style_defaults');
10+
var handleHeatmapLabelDefaults = require('../heatmap/label_defaults');
1011
var attributes = require('./attributes');
1112

1213

@@ -48,10 +49,6 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
4849
traceOut.contours &&
4950
traceOut.contours.coloring === 'heatmap'
5051
) {
51-
coerce('texttemplate');
52-
53-
var fontDflt = Lib.extendFlat({}, layout.font);
54-
fontDflt.color = undefined; // color contrast by default
55-
Lib.coerceFont(coerce, 'textfont', fontDflt);
52+
handleHeatmapLabelDefaults(coerce, layout);
5653
}
5754
};

src/traces/heatmap/defaults.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
var Lib = require('../../lib');
44

55
var handleXYZDefaults = require('./xyz_defaults');
6+
var handleHeatmapLabelDefaults = require('./label_defaults');
67
var handlePeriodDefaults = require('../scatter/period_defaults');
78
var handleStyleDefaults = require('./style_defaults');
89
var colorscaleDefaults = require('../../components/colorscale/defaults');
@@ -27,12 +28,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
2728
coerce('text');
2829
coerce('hovertext');
2930
coerce('hovertemplate');
30-
coerce('texttemplate');
31-
32-
var fontDflt = Lib.extendFlat({}, layout.font);
33-
fontDflt.color = undefined; // color contrast by default
34-
Lib.coerceFont(coerce, 'textfont', fontDflt);
3531

32+
handleHeatmapLabelDefaults(coerce, layout);
3633
handleStyleDefaults(traceIn, traceOut, coerce, layout);
3734

3835
coerce('hoverongaps');

src/traces/heatmap/label_defaults.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
'use strict';
2+
3+
var Lib = require('../../lib');
4+
5+
module.exports = function handleHeatmapLabelDefaults(coerce, layout) {
6+
coerce('texttemplate');
7+
8+
var fontDflt = Lib.extendFlat({}, layout.font);
9+
fontDflt.color = undefined; // color contrast by default
10+
Lib.coerceFont(coerce, 'textfont', fontDflt);
11+
};

src/traces/histogram2d/defaults.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ var Lib = require('../../lib');
55
var handleSampleDefaults = require('./sample_defaults');
66
var handleStyleDefaults = require('../heatmap/style_defaults');
77
var colorscaleDefaults = require('../../components/colorscale/defaults');
8+
var handleHeatmapLabelDefaults = require('../heatmap/label_defaults');
89
var attributes = require('./attributes');
910

1011

@@ -19,11 +20,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
1920
handleStyleDefaults(traceIn, traceOut, coerce, layout);
2021
colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: '', cLetter: 'z'});
2122
coerce('hovertemplate');
22-
coerce('texttemplate');
2323

24-
var fontDflt = Lib.extendFlat({}, layout.font);
25-
fontDflt.color = undefined; // color contrast by default
26-
Lib.coerceFont(coerce, 'textfont', fontDflt);
24+
handleHeatmapLabelDefaults(coerce, layout);
2725

2826
coerce('xhoverformat');
2927
coerce('yhoverformat');

src/traces/histogram2dcontour/defaults.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ var Lib = require('../../lib');
55
var handleSampleDefaults = require('../histogram2d/sample_defaults');
66
var handleContoursDefaults = require('../contour/contours_defaults');
77
var handleStyleDefaults = require('../contour/style_defaults');
8+
var handleHeatmapLabelDefaults = require('../heatmap/label_defaults');
89
var attributes = require('./attributes');
910

1011

@@ -29,10 +30,6 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
2930
traceOut.contours &&
3031
traceOut.contours.coloring === 'heatmap'
3132
) {
32-
coerce('texttemplate');
33-
34-
var fontDflt = Lib.extendFlat({}, layout.font);
35-
fontDflt.color = undefined; // color contrast by default
36-
Lib.coerceFont(coerce, 'textfont', fontDflt);
33+
handleHeatmapLabelDefaults(coerce, layout);
3734
}
3835
};

0 commit comments

Comments
 (0)