Skip to content

Commit 31836f2

Browse files
committed
✏️ splom meta description + register grid in splom index
1 parent a79f5dc commit 31836f2

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

src/traces/splom/index.js

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
var createMatrix = require('regl-scattermatrix');
1212
var arrayRange = require('array-range');
1313

14+
var Registry = require('../../registry');
15+
var Grid = require('../../components/grid');
1416
var Lib = require('../../lib');
1517
var AxisIDs = require('../../plots/cartesian/axis_ids');
1618

@@ -179,7 +181,7 @@ function plotOne(gd, cd0) {
179181
if(cdata.length === 0) return;
180182

181183
// augment options with proper upper/lower halves
182-
// regl-scattermatrix's default grid start from bottom-left
184+
// regl-scattermatrix's default grid starts from bottom-left
183185
matrixOpts.lower = trace.showupperhalf;
184186
matrixOpts.upper = trace.showlowerhalf;
185187
matrixOpts.diagonal = trace.diagonal.visible;
@@ -294,8 +296,6 @@ function plotOne(gd, cd0) {
294296
scene.draw();
295297
}
296298

297-
// TODO splom 'needs' the grid component, register it here?
298-
299299
function hoverPoints(pointData, xval, yval) {
300300
var cd = pointData.cd;
301301
var trace = cd[0].trace;
@@ -473,7 +473,16 @@ module.exports = {
473473

474474
meta: {
475475
description: [
476-
'SPLOM !!!'
476+
'Splom traces generate scatter plot matrix visualizations.',
477+
'Each splom `dimensions` items correspond to an generated axes.',
478+
'Values for each of those dimensions are set in `dimensions[i].values`.',
479+
'Splom traces support all `scattergl` marker style attributes.',
480+
'Specify `layout.grid` attributes and/or layout x-axis and y-axis attributes',
481+
'for control '
477482
].join(' ')
478483
}
479484
};
485+
486+
// splom traces use the 'grid' component to generate their axes,
487+
// register it here
488+
Registry.register(Grid);

0 commit comments

Comments
 (0)