Changed rangeslidermode values for more clarity

Author: TomDemulierChevret

src/components/rangeslider/draw.js

@@ -136,7 +136,7 @@ module.exports = function(gd) {
 
         opts._rl = [range0, range1];
 
-        if(oppAxisOpts.rangeslidermode) {
+        if(oppAxisOpts.rangeslidermode === 'auto' || oppAxisOpts.rangeslidermode === 'fixed') {
             var range0OppAxis = oppAxisOpts.r2l(oppAxisOpts.rangesliderrange[0]),
                 range1OppAxis = oppAxisOpts.r2l(oppAxisOpts.rangesliderrange[1]),
                 distOppAxis = range1OppAxis - range0OppAxis;
@@ -305,7 +305,7 @@ function setPixelRange(rangeSlider, gd, axisOpts, opts, oppAxisOpts) {
         .attr('x', pixelMax)
         .attr('width', opts._width - pixelMax);
 
-    if(oppAxisOpts.rangeslidermode) {
+    if(oppAxisOpts.rangeslidermode === 'auto' || oppAxisOpts.rangeslidermode === 'fixed') {
         var pixelMinOppAxis = opts._height - clampOppAxis(opts.d2pOppAxis(oppAxisOpts._rl[1])),
             pixelMaxOppAxis = opts._height - clampOppAxis(opts.d2pOppAxis(oppAxisOpts._rl[0]));
 
@@ -428,7 +428,7 @@ function drawRangePlot(rangeSlider, gd, axisOpts, opts) {
         mockFigure.layout[oppAxisName] = {
             type: oppAxisOpts.type,
             domain: [0, 1],
-            range: oppAxisOpts.rangeslidermode ? oppAxisOpts.rangesliderrange.slice() : oppAxisOpts.range.slice(),
+            range: (oppAxisOpts.rangeslidermode === 'auto' || oppAxisOpts.rangeslidermode === 'fixed') ? oppAxisOpts.rangesliderrange.slice() : oppAxisOpts.range.slice(),
             calendar: oppAxisOpts.calendar
         };
 
@@ -495,7 +495,7 @@ function drawMasks(rangeSlider, gd, axisOpts, opts, oppAxisOpts) {
         .call(Color.fill, constants.maskColor);
 
     // masks used for oppAxis zoom
-    if(oppAxisOpts.rangeslidermode) {
+    if(oppAxisOpts.rangeslidermode === 'auto' || oppAxisOpts.rangeslidermode === 'fixed') {
         var maskMinOppAxis = rangeSlider.selectAll('rect.' + constants.maskMinOppAxisClassName)
             .data([0]);
 

src/plots/cartesian/axis_defaults.js

@@ -55,8 +55,13 @@ module.exports = function handleAxisDefaults(containerIn, containerOut, coerce,
     containerOut.cleanRange();
 
     if(letter === 'y') {
-        coerce('rangeslidermode', containerIn.rangesliderrange ?
-            containerOut.isValidRange(containerIn.rangesliderrange) : 'auto');
+        if(containerIn.rangesliderrange) {
+            coerce('rangeslidermode', 'auto');
+        } else if(containerOut.isValidRange(containerIn.rangesliderrange)) {
+            coerce('rangeslidermode', 'fixed');
+        } else {
+            coerce('rangeslidermode', 'match');
+        }
 
         coerce('rangesliderrange');
         containerOut.cleanRange('rangesliderrange');

src/plots/cartesian/layout_attributes.js

@@ -130,7 +130,7 @@ module.exports = {
     },
     rangeslidermode: {
         valType: 'enumerated',
-        values: ['auto', true, false],
+        values: ['auto', 'fixed', 'match'],
         dflt: 'auto',
         role: 'style',
         editType: 'calc',
@@ -139,8 +139,8 @@ module.exports = {
             'the rangeslider use the same value than in the main plot',
             'when zooming in/out.',
             'If *auto*, the autorange will be used.',
-            'If *true*, the `rangesliderrange` is used.',
-            'If *false*, the current range is used.'
+            'If *fixed*, the `rangesliderrange` is used.',
+            'If *match*, the current range is used.'
         ].join(' ')
     },
     rangesliderrange: {