slice cols before reversing - inplace reverse

Author: richardnm-2

devtools/test_dashboard/index.html

@@ -244,7 +244,7 @@
       trace = {
         x: [
           ["AA", "AA", "AA", "BB"],
-          ["DD", "CC", "DD", "DD"],
+          ["CC", "DD", "FF", "CC"],
         ],
 
         y: [12, 10, 13, 14],

src/lib/sort_traces.js

@@ -39,7 +39,7 @@ function sortObjectList(cols, objList) {
     var sortedObjectList = objList.map(function(e) {
         return e;
     });
-    cols.reverse().forEach(function(key) {
+    cols.slice().reverse().forEach(function(key) {
         sortedObjectList = sortedObjectList.sort(function(a, b) {
             return sortObjecstByKey(a, b, key);
         });

src/plots/cartesian/set_convert.js

@@ -379,18 +379,19 @@ module.exports = function setConvert(ax, fullLayout) {
 
             var xs = [];
             var fullObjectList = [];
+            var cols = [];
+
+            for(var k = 0; k < fullData[traceIndices[0]][axLetter].length; k++) {
+                cols.push('col' + k.toString());
+            }
 
             for(i = 0; i < traceIndices.length; i++) {
                 var trace = fullData[traceIndices[i]];
-                var cols = [];
 
                 if(axLetter in trace) {
                     var arrayIn = trace[axLetter];
                     // var arrayIn = trace[axLetter].slice(0, 2);
 
-                    for(var k = 0; k < arrayIn.length; k++) {
-                        cols.push('col' + k.toString());
-                    }
 
                     if(isArrayOrTypedArray(arrayIn[0]) && isArrayOrTypedArray(arrayIn[1])) {
                         var arrays = arrayIn.map(function(x) {
@@ -423,7 +424,7 @@ module.exports = function setConvert(ax, fullLayout) {
             ax.levels = xs[0].map(function(_, idx) {return idx;});
 
             console.log('fullObjectList', fullObjectList);
-            var fullSortedObjectList = sortLib.sortObjectList(cols, fullObjectList);
+            var fullSortedObjectList = sortLib.sortObjectList(cols, fullObjectList.slice());
             var fullList = sortLib.objectListToList(fullSortedObjectList);
             var fullSortedMatrix = sortLib.sortedMatrix(fullList);