Skip to content

Commit 46fcf8f

Browse files
committed
handle all negatives
1 parent 69f4027 commit 46fcf8f

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/traces/bar/cross_trace_calc.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -502,6 +502,7 @@ function setBaseAndTop(sa, sieve) {
502502
var fullTrace = calcTrace[0].trace;
503503
var pts = [];
504504
var allBaseAboveZero = true;
505+
var allBaseBelowZero = true;
505506

506507
for(var j = 0; j < calcTrace.length; j++) {
507508
var bar = calcTrace[j];
@@ -515,10 +516,14 @@ function setBaseAndTop(sa, sieve) {
515516
if(!bar.hasB || !(bar.b > 0 && bar.b + bar.s > 0)) {
516517
allBaseAboveZero = false;
517518
}
519+
520+
if(!bar.hasB || !(bar.b < 0 && bar.b + bar.s < 0)) {
521+
allBaseBelowZero = false;
522+
}
518523
}
519524

520525
fullTrace._extremes[sa._id] = Axes.findExtremes(sa, pts, {
521-
tozero: !allBaseAboveZero,
526+
tozero: !(allBaseAboveZero || allBaseBelowZero),
522527
padded: true
523528
});
524529
}
2.85 KB
Loading

0 commit comments

Comments
 (0)