remove duplicate draw call for axes with tickmode: 'sync'

emilykl · emilykl · commit 4d5746a7580f · 2026-01-08T10:07:54.000-05:00
diff --git a/src/plots/cartesian/dragbox.js b/src/plots/cartesian/dragbox.js
@@ -732,7 +732,10 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
             for(i = 0; i < axList.length; i++) {
                 var axListI = axList[i];
                 var axListIType = axListI[axisType];
-                if(!axListI.fixedrange && axListIType.tickmode === 'sync') activeAxIds.push(axListIType._id);
+                var axId = axListIType._id;
+                if(!axListI.fixedrange && axListIType.tickmode === 'sync' && activeAxIds.indexOf(axId) === -1) {
+                    activeAxIds.push(axId);
+                }
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -732,7 +732,10 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {`
`732`	`732`	`for(i = 0; i < axList.length; i++) {`
`733`	`733`	`var axListI = axList[i];`
`734`	`734`	`var axListIType = axListI[axisType];`
`735`		`- if(!axListI.fixedrange && axListIType.tickmode === 'sync') activeAxIds.push(axListIType._id);`
	`735`	`+ var axId = axListIType._id;`
	`736`	`+ if(!axListI.fixedrange && axListIType.tickmode === 'sync' && activeAxIds.indexOf(axId) === -1) {`
	`737`	`+ activeAxIds.push(axId);`
	`738`	`+ }`
`736`	`739`	`}`
`737`	`740`	`}`
`738`	`741`