address various treemap transition case e.g. maxdepth, tweening and pathbar position

- i.e. with the help of etpinard
- make treemap transition NOT depend on "clicked" stash
- during exit transitions, look for previous coords of current entry
  node, which corresponds to the last "clicked" node when zooming in
- during update transition of new pts, look for "next" coords of
  previous entry node, corresponding to a zoom out interaction
- extract "find closest edge" logic from `getOrgin` into own function
- compute nextOfPrevEntry after partition is computed
- display pathbar outside trace domain
- dont draw empty rectangles as lines

Author: archmoj

src/traces/sunburst/fx.js

@@ -263,23 +263,7 @@ module.exports = function attachFxHandlers(sliceTop, entry, gd, cd, opts) {
         });
 
         var id = helpers.getPtId(pt);
-        var isEntry = helpers.isEntry(pt);
-
-        if(isTreemap) {
-            var zoomOut = true;
-            var redirectId = pt._redirect;
-            if(redirectId === undefined) {
-                redirectId = id;
-                if(!isEntry) zoomOut = false;
-            }
-
-            traceNow._clickedInfo = {
-                id: redirectId,
-                zoomOut: zoomOut
-            };
-        }
-
-        var nextEntry = isEntry ?
+        var nextEntry = helpers.isEntry(pt) ?
             helpers.findEntryWithChild(hierarchy, id) :
             helpers.findEntryWithLevel(hierarchy, id);
 

src/traces/sunburst/helpers.js

@@ -42,25 +42,6 @@ exports.findEntryWithChild = function(hierarchy, childId) {
     return out || hierarchy;
 };
 
-exports.findChildPt = function(hierarchy, childId) {
-    var out = {};
-    hierarchy.eachAfter(function(pt) {
-        var children = pt.children || [];
-        for(var i = 0; i < children.length; i++) {
-            var child = children[i];
-            if(exports.getPtId(child) === childId) {
-                out = {
-                    x0: child.x0,
-                    x1: child.x1,
-                    y0: child.y0,
-                    y1: child.y1,
-                };
-            }
-        }
-    });
-    return out;
-};
-
 exports.isEntry = function(pt) {
     return !pt.parent;
 };

src/traces/treemap/draw_ancestors.js

@@ -69,8 +69,6 @@ module.exports = function drawAncestors(gd, cd, entry, slices, opts) {
         pt.y0 = barDifY + 0;
         pt.y1 = barDifY + height;
 
-        pt._redirect = entry.data.id;
-
         return true;
     });
 

src/traces/treemap/draw_descendants.js

@@ -34,6 +34,7 @@ module.exports = function drawDescendants(gd, cd, entry, slices, opts) {
     var handleSlicesExit = opts.handleSlicesExit;
     var makeUpdateSliceInterpolator = opts.makeUpdateSliceInterpolator;
     var makeUpdateTextInterpolator = opts.makeUpdateTextInterpolator;
+    var prevEntry = opts.prevEntry;
     var refRect = {};
 
     var fullLayout = gd._fullLayout;
@@ -62,17 +63,17 @@ module.exports = function drawDescendants(gd, cd, entry, slices, opts) {
         }
     });
 
-    var getRefRect = function() {
-        if(!trace._clickedInfo) return refRect;
-        return helpers.findChildPt(allData, trace._clickedInfo.id);
-    };
-
     var sliceData = allData.descendants();
 
-    // filter out slices that won't show up on graph
-    sliceData = sliceData.filter(function(pt) { return pt.depth < trace._maxDepth; });
+    slices = slices.data(sliceData, function(pt) {
+        // hide slices that won't show up on graph
+        if(pt.depth >= trace._maxDepth) {
+            pt.x0 = pt.x1 = (pt.x0 + pt.x1) / 2;
+            pt.y0 = pt.y1 = (pt.y0 + pt.y1) / 2;
+        }
 
-    slices = slices.data(sliceData, function(pt) { return helpers.getPtId(pt); });
+        return helpers.getPtId(pt);
+    });
 
     slices.enter().append('g')
         .classed('slice', true);
@@ -81,6 +82,31 @@ module.exports = function drawDescendants(gd, cd, entry, slices, opts) {
 
     slices.order();
 
+    // next coords of previous entry
+    var nextOfPrevEntry = null;
+    if(hasTransition && prevEntry) {
+        var prevEntryId = helpers.getPtId(prevEntry);
+        slices.each(function(pt) {
+            if(nextOfPrevEntry === null && (helpers.getPtId(pt) === prevEntryId)) {
+                nextOfPrevEntry = {
+                    x0: pt.x0,
+                    x1: pt.x1,
+                    y0: pt.y0,
+                    y1: pt.y1
+                };
+            }
+        });
+    }
+
+    var getRefRect = function() {
+        return nextOfPrevEntry || {
+            x0: 0,
+            x1: width,
+            y0: 0,
+            y1: height
+        };
+    };
+
     var updateSlices = slices;
     if(hasTransition) {
         updateSlices = updateSlices.transition().each('end', function() {
@@ -177,4 +203,6 @@ module.exports = function drawDescendants(gd, cd, entry, slices, opts) {
             sliceText.attr('transform', strTransform(pt));
         }
     });
+
+    return nextOfPrevEntry;
 };