return jquery event handler return value even when no node events present

Author: bpostlethwaite

shelly/plotlyjs/static/plotlyjs/src/events.js

@@ -73,10 +73,10 @@ var Events = {
          * Now run all the node style event handlers
          */
         var ev = plotObj._ev;
-        if (!ev) return;
+        if (!ev) return jQueryHandlerValue;
 
         var handlers = ev._events[event];
-        if (!handlers) return;
+        if (!handlers) return jQueryHandlerValue;
 
         /*
          * handlers can be function or an array of functions

shelly/plotlyjs/static/plotlyjs/tests/events_test.js

@@ -100,6 +100,59 @@ describe('Events', function () {
             expect(result).toBe('pong');
         });
 
+        it('triggers jQuery handlers when no node events initialized', function() {
+            var eventBaton = 0;
+
+            Events.init(plotDiv);
+
+            $(plotDiv).bind('ping', function() {
+                eventBaton++;
+                return 'ping';
+            });
+
+            /*
+             * This will not be called
+             */
+            plotDiv.on('pong', function() {
+                eventBaton++;
+                return 'ping';
+            });
+
+            $(plotDiv).bind('ping', function() {
+                eventBaton++;
+                return 'pong';
+            });
+
+            var result = Events.triggerHandler(plotDiv, 'ping');
+
+            expect(eventBaton).toBe(2);
+            expect(result).toBe('pong');
+        });
+
+        it('triggers jQuery handlers when no matching node events bound', function() {
+            var eventBaton = 0;
+
+            $(plotDiv).bind('ping', function() {
+                eventBaton++;
+                return 'ping';
+            });
+
+            $(plotDiv).bind('ping', function() {
+                eventBaton++;
+                return 'ping';
+            });
+
+            $(plotDiv).bind('ping', function() {
+                eventBaton++;
+                return 'pong';
+            });
+
+            var result = Events.triggerHandler(plotDiv, 'ping');
+
+            expect(eventBaton).toBe(3);
+            expect(result).toBe('pong');
+        });
+
 
         it('triggers jQuery + nodejs handlers and returns last jQuery value', function() {
             var eventBaton = 0;