handle typed arrays in table

Author: archmoj

src/traces/table/data_preparation_helper.js

@@ -3,6 +3,7 @@
 var c = require('./constants');
 var extendFlat = require('../../lib/extend').extendFlat;
 var isNumeric = require('fast-isnumeric');
+var isArrayOrTypedArray = require('../../lib/array').isArrayOrTypedArray;
 
 // pure functions, don't alter but passes on `gd` and parts of `trace` without deep copying
 module.exports = function calc(gd, trace) {
@@ -35,9 +36,13 @@ module.exports = function calc(gd, trace) {
     var headerRowBlocks = makeRowBlock(anchorToHeaderRowBlock, []);
     var rowBlocks = makeRowBlock(anchorToRowBlock, headerRowBlocks);
     var uniqueKeys = {};
-    var columnOrder = trace._fullInput.columnorder.concat(slicer(cellsValues.map(function(d, i) {return i;})));
+
+    var columnOrder = trace._fullInput.columnorder;
+    if(isArrayOrTypedArray(columnOrder)) columnOrder = Array.from(columnOrder);
+    columnOrder = columnOrder.concat(slicer(cellsValues.map(function(d, i) {return i;})));
+
     var columnWidths = headerValues.map(function(d, i) {
-        var value = Array.isArray(trace.columnwidth) ?
+        var value = isArrayOrTypedArray(trace.columnwidth) ?
             trace.columnwidth[Math.min(i, trace.columnwidth.length - 1)] :
             trace.columnwidth;
         return isNumeric(value) ? Number(value) : 1;
@@ -95,7 +100,7 @@ module.exports = function calc(gd, trace) {
 };
 
 function arrayMax(maybeArray) {
-    if(Array.isArray(maybeArray)) {
+    if(isArrayOrTypedArray(maybeArray)) {
         var max = 0;
         for(var i = 0; i < maybeArray.length; i++) {
             max = Math.max(max, arrayMax(maybeArray[i]));
@@ -115,7 +120,7 @@ function squareStringMatrix(matrixIn) {
     var maxLen = 0;
     var i;
     for(i = 0; i < matrix.length; i++) {
-        if(!Array.isArray(matrix[i])) matrix[i] = [matrix[i]];
+        if(!isArrayOrTypedArray(matrix[i])) matrix[i] = [matrix[i]];
         minLen = Math.min(minLen, matrix[i].length);
         maxLen = Math.max(maxLen, matrix[i].length);
     }

src/traces/table/plot.js

@@ -600,9 +600,9 @@ function columnMoved(gd, calcdata, indices) {
 }
 
 function gridPick(spec, col, row) {
-    if(Array.isArray(spec)) {
+    if(Lib.isArrayOrTypedArray(spec)) {
         var column = spec[Math.min(col, spec.length - 1)];
-        if(Array.isArray(column)) {
+        if(Lib.isArrayOrTypedArray(column)) {
             return column[Math.min(row, column.length - 1)];
         } else {
             return column;