add tiling orientation for icicle

Author: archmoj

src/traces/icicle/attributes.js

@@ -22,6 +22,18 @@ module.exports = {
     maxdepth: sunburstAttrs.maxdepth,
 
     tiling: {
+        orientation: {
+            valType: 'enumerated',
+            values: ['v', 'h'],
+            dflt: 'h',
+            editType: 'plot',
+            description: [
+                'Sets the orientation of the icicle.',
+                'With *v* the icicle grows vertically.',
+                'With *h* the icicle grows horizontally.',
+            ].join(' ')
+        },
+
         flip: {
             valType: 'flaglist',
             flags: [

src/traces/icicle/defaults.js

@@ -34,6 +34,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     coerce('level');
     coerce('maxdepth');
 
+    coerce('tiling.orientation');
     coerce('tiling.flip');
     coerce('tiling.pad');
 

src/traces/icicle/draw_descendants.js

@@ -40,10 +40,9 @@ module.exports = function drawDescendants(gd, cd, entry, slices, opts) {
     // N.B. slice data isn't the calcdata,
     // grab corresponding calcdata item in sliceData[i].data.data
     var allData = partition(entry, [width, height], {
-        packing: trace.tiling.packing,
-        squarifyratio: trace.tiling.squarifyratio,
         flipX: trace.tiling.flip.indexOf('x') > -1,
         flipY: trace.tiling.flip.indexOf('y') > -1,
+        orientation: trace.tiling.orientation,
         pad: {
             inner: trace.tiling.pad
         }

src/traces/icicle/partition.js

@@ -5,14 +5,18 @@ var d3Hierarchy = require('d3-hierarchy');
 module.exports = function partition(entry, size, opts) {
     var flipX = opts.flipX;
     var flipY = opts.flipY;
+    var swapXY = opts.orientation === 'h';
 
     var result = d3Hierarchy
         .partition()
         .padding(opts.pad.inner)
-        .size(size)(entry);
+        .size(
+            swapXY ? [size[1], size[0]] : size
+        )(entry);
 
-    if(flipX || flipY) {
+    if(swapXY || flipX || flipY) {
         flipTree(result, size, {
+            swapXY: swapXY,
             flipX: flipX,
             flipY: flipY
         });
@@ -23,6 +27,18 @@ module.exports = function partition(entry, size, opts) {
 function flipTree(node, size, opts) {
     var tmp;
 
+    if(opts.swapXY) {
+        // swap x0 and y0
+        tmp = node.x0;
+        node.x0 = node.y0;
+        node.y0 = tmp;
+
+        // swap x1 and y1
+        tmp = node.x1;
+        node.x1 = node.y1;
+        node.y1 = tmp;
+    }
+
     if(opts.flipX) {
         tmp = node.x0;
         node.x0 = size[0] - node.x1;