add box plot tests an improve gl3d tests

Author: archmoj

test/jasmine/tests/box_test.js

@@ -636,6 +636,86 @@ describe('Test boxes supplyDefaults', function() {
     });
 });
 
+describe('Test box converting numeric strings', function() {
+    it('should disable converting numeric strings using axis.convertnumeric', function() {
+        var gd = {
+            layout: {
+                xaxis: {
+                    convertnumeric: false
+                }
+            },
+            data: [{
+                type: 'box',
+                x: ['3', '0', '1', '2'],
+
+                xaxis: 'x',
+                lowerfence: ['0', '0', '0', '0'],
+                q1: ['0.5', '1', '1.5', '2'],
+                median: ['1', '2', '3', '4'],
+                q3: ['1.5', '3', '4.5', '6'],
+                upperfence: ['2', '4', '6', '8'],
+            }]
+        };
+
+        supplyAllDefaults(gd);
+
+        expect(gd._fullLayout.xaxis.convertnumeric).toBe(false);
+        expect(gd._fullLayout.xaxis.type).toBe('category');
+    });
+
+    it('should enable converting numeric strings using axis.convertnumeric', function() {
+        var gd = {
+            layout: {
+                axesconvertnumeric: false,
+                xaxis: {
+                    convertnumeric: true
+                }
+            },
+            data: [{
+                type: 'box',
+                x: ['3', '0', '1', '2'],
+
+                xaxis: 'x',
+                lowerfence: ['0', '0', '0', '0'],
+                q1: ['0.5', '1', '1.5', '2'],
+                median: ['1', '2', '3', '4'],
+                q3: ['1.5', '3', '4.5', '6'],
+                upperfence: ['2', '4', '6', '8'],
+            }]
+        };
+
+        supplyAllDefaults(gd);
+
+        expect(gd._fullLayout.xaxis.convertnumeric).toBe(true);
+        expect(gd._fullLayout.xaxis.type).toBe('linear');
+    });
+
+    it('should enable converting numeric inherit defaults from layout.axesconvertnumeric', function() {
+        var gd = {
+            layout: {
+                axesconvertnumeric: false,
+                xaxis: {}
+            },
+            data: [{
+                type: 'box',
+                x: ['3', '0', '1', '2'],
+
+                xaxis: 'x',
+                lowerfence: ['0', '0', '0', '0'],
+                q1: ['0.5', '1', '1.5', '2'],
+                median: ['1', '2', '3', '4'],
+                q3: ['1.5', '3', '4.5', '6'],
+                upperfence: ['2', '4', '6', '8'],
+            }]
+        };
+
+        supplyAllDefaults(gd);
+
+        expect(gd._fullLayout.xaxis.convertnumeric).toBe(false);
+        expect(gd._fullLayout.xaxis.type).toBe('category');
+    });
+});
+
 describe('Test box hover:', function() {
     var gd;
 

test/jasmine/tests/gl3dlayout_test.js

@@ -387,29 +387,23 @@ describe('Test Gl3d layout defaults', function() {
         it('should disable converting numeric strings using axis.convertnumeric', function() {
             supplyLayoutDefaults({
                 scene: {
-                    xaxis: {
-                        convertnumeric: false
-                    },
-                    yaxis: {
-                        convertnumeric: false
-                    },
-                    zaxis: {
-                        convertnumeric: false
-                    }
+                    xaxis: { convertnumeric: false },
+                    yaxis: {},
+                    zaxis: { convertnumeric: false }
                 }
             }, layoutOut, [{
                 type: 'scatter3d',
-                x: ['0', '1', '1970', '2000'],
-                y: ['0', '1', '1970', '2000'],
-                z: ['0', '1', '1970', '2000'],
+                x: ['1970', '2000', '0', '1'],
+                y: ['1970', '2000', '0', '1'],
+                z: ['1970', '2000', '0', '1'],
                 scene: 'scene'
             }]);
 
             expect(layoutOut.scene.xaxis.convertnumeric).toBe(false);
-            expect(layoutOut.scene.yaxis.convertnumeric).toBe(false);
+            expect(layoutOut.scene.yaxis.convertnumeric).toBe(true);
             expect(layoutOut.scene.zaxis.convertnumeric).toBe(false);
             expect(layoutOut.scene.xaxis.type).toBe('category');
-            expect(layoutOut.scene.yaxis.type).toBe('category');
+            expect(layoutOut.scene.yaxis.type).toBe('linear');
             expect(layoutOut.scene.zaxis.type).toBe('category');
         });
 
@@ -418,29 +412,23 @@ describe('Test Gl3d layout defaults', function() {
 
             supplyLayoutDefaults({
                 scene: {
-                    xaxis: {
-                        convertnumeric: true
-                    },
-                    yaxis: {
-                        convertnumeric: true
-                    },
-                    zaxis: {
-                        convertnumeric: true
-                    }
+                    xaxis: { convertnumeric: true },
+                    yaxis: {},
+                    zaxis: { convertnumeric: true }
                 }
             }, layoutOut, [{
                 type: 'scatter3d',
-                x: ['0', '1', '1970', '2000'],
-                y: ['0', '1', '1970', '2000'],
-                z: ['0', '1', '1970', '2000'],
+                x: ['1970', '2000', '0', '1'],
+                y: ['1970', '2000', '0', '1'],
+                z: ['1970', '2000', '0', '1'],
                 scene: 'scene'
             }]);
 
             expect(layoutOut.scene.xaxis.convertnumeric).toBe(true);
-            expect(layoutOut.scene.yaxis.convertnumeric).toBe(true);
+            expect(layoutOut.scene.yaxis.convertnumeric).toBe(false);
             expect(layoutOut.scene.zaxis.convertnumeric).toBe(true);
             expect(layoutOut.scene.xaxis.type).toBe('linear');
-            expect(layoutOut.scene.yaxis.type).toBe('linear');
+            expect(layoutOut.scene.yaxis.type).toBe('category');
             expect(layoutOut.scene.zaxis.type).toBe('linear');
         });
     });