refactoring if statements in shaders and scene

Author: archmoj

package-lock.json

@@ -70,21 +70,21 @@
     "es6-promise": "^3.0.2",
     "fast-isnumeric": "^1.1.1",
     "font-atlas-sdf": "^1.3.3",
-    "gl-cone3d": "git://github.com/archmoj/gl-cone3d.git#823cabfbb19d8b457730320010cb58df748ff9ee",
+    "gl-cone3d": "git://github.com/archmoj/gl-cone3d.git#2f1afdb49bd09e28ea32604b13aea919c0a57330",
     "gl-contour2d": "^1.1.4",
-    "gl-error3d": "git://github.com/archmoj/gl-error3d.git#d09c224fe25671fcd588a8c803fe83129156fbab",
+    "gl-error3d": "git://github.com/archmoj/gl-error3d.git#6b5180b0ed024430ccbafb7392dac087bb2c12c4",
     "gl-heatmap2d": "^1.0.4",
-    "gl-line3d": "git://github.com/archmoj/gl-line3d.git#681398a5477f64cfd92ff7494215d5b6854e834b",
+    "gl-line3d": "git://github.com/archmoj/gl-line3d.git#3f3e383004309507df9ce42490d85da070effafa",
     "gl-mat4": "^1.2.0",
-    "gl-mesh3d": "git://github.com/archmoj/gl-mesh3d.git#5828f6255d8c5360631d5feec65801bb104a88e8",
+    "gl-mesh3d": "git://github.com/archmoj/gl-mesh3d.git#b2da71e9cc4719ee5b6a69398651e578cef2f3c0",
     "gl-plot2d": "^1.3.1",
     "gl-plot3d": "git://github.com/archmoj/gl-plot3d.git#ce601a50cd3057899f6074f8ea5fcf0ab77f417c",
     "gl-pointcloud2d": "^1.0.1",
-    "gl-scatter3d": "git://github.com/archmoj/gl-scatter3d.git#b649f8fb619242525b64ccf1def62cb2ed3f224f",
+    "gl-scatter3d": "git://github.com/archmoj/gl-scatter3d.git#da56cdc37d4386261539d5134a5f9a39fe878415",
     "gl-select-box": "^1.0.2",
     "gl-spikes2d": "^1.0.1",
-    "gl-streamtube3d": "git://github.com/archmoj/gl-streamtube3d.git#f4f5a63ffb19704a1ab1cadcc7aa848d7b68f7bf",
-    "gl-surface3d": "git://github.com/archmoj/gl-surface3d.git#2455aad56d3727b940fad8d02727806abca0fdf4",
+    "gl-streamtube3d": "git://github.com/archmoj/gl-streamtube3d.git#08ce753c40e2804f33738de987da5c10ec8c67c0",
+    "gl-surface3d": "git://github.com/archmoj/gl-surface3d.git#cb6ef0af1b3d992112b9bfc83dcf2b4e4736e2d0",
     "gl-text": "^1.1.6",
     "glslify": "^6.3.1",
     "has-hover": "^1.0.1",

package.json

@@ -383,13 +383,6 @@ function computeTraceBounds(scene, trace, bounds) {
     }
 }
 
-function isCloseToZero(a) {
-    if(Math.abs(a) > Number.MIN_VALUE) { // the smallest positive numeric value representable in JavaScript
-        return false;
-    }
-    return true;
-}
-
 proto.plot = function(sceneData, fullLayout, layout) {
 
     // Save parameters
@@ -442,8 +435,12 @@ proto.plot = function(sceneData, fullLayout, layout) {
     }
     var dataScale = [1, 1, 1];
     for(j = 0; j < 3; ++j) {
-        var diff = dataBounds[1][j] - dataBounds[0][j];
-        if(!isCloseToZero(diff)) dataScale[j] = 1.0 / diff;
+        if(dataBounds[1][j] === dataBounds[0][j]) {
+            dataScale[j] = 1.0;
+        }
+        else {
+            dataScale[j] = 1.0 / (dataBounds[1][j] - dataBounds[0][j]);
+        }
     }
 
     // Save scale