Skip to content

Commit 668d7ee

Browse files
committed
Fix undefined offsets/baseline
1 parent e09a4e1 commit 668d7ee

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

src/traces/scattergl/convert.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,13 +193,12 @@ function convertTextfont(trace, textfont) {
193193
var size = sizes.length > 1 ? sizes[i] : sizes[0];
194194
var markerRadius = size / 2;
195195
var fontSize = Array.isArray(textOptions.font) ? textOptions.font[i].size : textOptions.font.size;
196-
var align = Array.isArray(textOptions.align) ? textOptions.align[i] : textOptions.align;
197-
var baseline = Array.isArray(textOptions.baseline) ? textOptions.baseline[i] : textOptions.baseline;
196+
var align = Array.isArray(textOptions.align) ? textOptions.align.length > 1 ? textOptions.align[i] : textOptions.align[0] : textOptions.align;
197+
var baseline = Array.isArray(textOptions.baseline) ? textOptions.baseline.length > 1 ? textOptions.baseline[i] : textOptions.baseline[0] : textOptions.baseline;
198198
var hSign = TEXTOFFSETSIGN[align];
199199
var vSign = TEXTOFFSETSIGN[baseline];
200200
var xPad = markerRadius ? markerRadius / 0.8 + 1 : 0;
201201
var yPad = - vSign * xPad - vSign * 0.5;
202-
203202
textOptions.offset.push(
204203
[hSign * xPad / fontSize, yPad / fontSize]
205204
);

src/traces/scattergl/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ var createLine = require('regl-line2d');
1313
var createError = require('regl-error2d');
1414
var cluster = require('point-cluster');
1515
var arrayRange = require('array-range');
16-
var Text = require('gl-text');
16+
var Text = require('../../../../gl-text/index');
1717

1818
var Registry = require('../../registry');
1919
var Lib = require('../../lib');
@@ -862,7 +862,7 @@ function selectPoints(searchInfo, polygon) {
862862
// update texts selection
863863
if(hasText) {
864864
var textOptions = {};
865-
if (els && unels) {
865+
if(els && unels) {
866866
if(els) {
867867
applyTextoption(textOptions, els, scene.selectedOptions[stash.index]);
868868
}

0 commit comments

Comments
 (0)