some linting

- assign contours.value to variable
- assign cd0.trace to variable
- apply Math.min and Math.max instead of using .apply (only 2 values)
- break up if clauses into multiple lines

Author: etpinard

src/traces/contour/close_boundaries.js

@@ -15,7 +15,7 @@ module.exports = function(pathinfo, operation, perimeter, trace) {
     var na = pi0.x.length;
     var nb = pi0.y.length;
     var z = pi0.z;
-    var contours = trace.contours;
+    var contoursValue = trace.contours.value;
 
     var boundaryMax = -Infinity;
     var boundaryMin = Infinity;
@@ -38,25 +38,25 @@ module.exports = function(pathinfo, operation, perimeter, trace) {
 
     switch(operation) {
         case '>':
-            if(contours.value > boundaryMax) {
+            if(contoursValue > boundaryMax) {
                 pi0.prefixBoundary = true;
             }
             break;
         case '<':
-            if(contours.value < boundaryMin) {
+            if(contoursValue < boundaryMin) {
                 pi0.prefixBoundary = true;
             }
             break;
         case '[]':
-            v1 = Math.min.apply(null, contours.value);
-            v2 = Math.max.apply(null, contours.value);
+            v1 = Math.min(contoursValue[0], contoursValue[1]);
+            v2 = Math.max(contoursValue[0], contoursValue[1]);
             if(v2 < boundaryMin || v1 > boundaryMax) {
                 pi0.prefixBoundary = true;
             }
             break;
         case '][':
-            v1 = Math.min.apply(null, contours.value);
-            v2 = Math.max.apply(null, contours.value);
+            v1 = Math.min(contoursValue[0], contoursValue[1]);
+            v2 = Math.max(contoursValue[0], contoursValue[1]);
             if(v1 < boundaryMin && v2 > boundaryMax) {
                 pi0.prefixBoundary = true;
             }

src/traces/contour/convert_to_constraints.js

@@ -37,10 +37,10 @@ module.exports = function(pathinfo, operation) {
             for(i = 0; i < pi0.edgepaths.length; i++) {
                 pi0.edgepaths[i] = op0(pi0.edgepaths[i]);
             }
-
             for(i = 0; i < pi0.paths.length; i++) {
                 pi0.paths[i] = op0(pi0.paths[i]);
             }
+
             return pathinfo;
         case '][':
             var tmp = op0;

src/traces/contour/plot.js

@@ -612,17 +612,18 @@ exports.drawLabels = function(labelGroup, labelData, gd, lineClip, labelClipPath
 };
 
 function clipGaps(plotGroup, plotinfo, gd, cd0, perimeter) {
+    var trace = cd0.trace;
     var clips = gd._fullLayout._clips;
-    var clipId = 'clip' + cd0.trace.uid;
+    var clipId = 'clip' + trace.uid;
 
     var clipPath = clips.selectAll('#' + clipId)
-        .data(cd0.trace.connectgaps ? [] : [0]);
+        .data(trace.connectgaps ? [] : [0]);
     clipPath.enter().append('clipPath')
         .classed('contourclip', true)
         .attr('id', clipId);
     clipPath.exit().remove();
 
-    if(cd0.trace.connectgaps === false) {
+    if(trace.connectgaps === false) {
         var clipPathInfo = {
             // fraction of the way from missing to present point
             // to draw the boundary.

src/traces/contourcarpet/join_all_paths.js

@@ -87,12 +87,14 @@ module.exports = function joinAllPaths(trace, pi, perimeter, ab2p, carpet, carpe
                 var ptNew = pi.edgepaths[possiblei][0];
                 // is ptNew on the (horz. or vert.) segment from endpt to newendpt?
                 if(Math.abs(endpt[0] - newendpt[0]) < atol) {
-                    if(Math.abs(endpt[0] - ptNew[0]) < atol && (ptNew[1] - endpt[1]) * (newendpt[1] - ptNew[1]) >= 0) {
+                    if(Math.abs(endpt[0] - ptNew[0]) < atol &&
+                            (ptNew[1] - endpt[1]) * (newendpt[1] - ptNew[1]) >= 0) {
                         newendpt = ptNew;
                         nexti = possiblei;
                     }
                 } else if(Math.abs(endpt[1] - newendpt[1]) < btol) {
-                    if(Math.abs(endpt[1] - ptNew[1]) < btol && (ptNew[0] - endpt[0]) * (newendpt[0] - ptNew[0]) >= 0) {
+                    if(Math.abs(endpt[1] - ptNew[1]) < btol &&
+                            (ptNew[0] - endpt[0]) * (newendpt[0] - ptNew[0]) >= 0) {
                         newendpt = ptNew;
                         nexti = possiblei;
                     }