Skip to content

Commit 715683f

Browse files
committed
fixup gl2d zoombox tests
... not sure why they pass previously, as both tests have assert small displacements that don't result in relayout to equal the base ranges AFTER modifying it with large-enough displacements.
1 parent 10f87a3 commit 715683f

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

test/jasmine/tests/gl_plot_interact_test.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1620,6 +1620,11 @@ describe('Test gl2d plots', function() {
16201620
centerX = bBox.left + 200;
16211621
centerY = bBox.top + 200;
16221622

1623+
// no change - too small
1624+
mouseTo([centerX, centerY], [centerX - 5, centerY + 5]);
1625+
expect(gd.layout.xaxis.range).toBeCloseToArray([0, 16], 3);
1626+
expect(gd.layout.yaxis.range).toBeCloseToArray([0, 16], 3);
1627+
16231628
// 2D
16241629
mouseTo([centerX - 50, centerY], [centerX + 50, centerY + 50]);
16251630
expect(gd.layout.xaxis.range).toBeCloseToArray([4, 12], 3);
@@ -1634,11 +1639,6 @@ describe('Test gl2d plots', function() {
16341639
mouseTo([centerX, centerY - 50], [centerX - 5, centerY + 50]);
16351640
expect(gd.layout.xaxis.range).toBeCloseToArray([6, 8], 3);
16361641
expect(gd.layout.yaxis.range).toBeCloseToArray([5, 7], 3);
1637-
1638-
// no change - too small
1639-
mouseTo([centerX, centerY], [centerX - 5, centerY + 5]);
1640-
expect(gd.layout.xaxis.range).toBeCloseToArray([0, 16], 3);
1641-
expect(gd.layout.yaxis.range).toBeCloseToArray([0, 16], 3);
16421642
})
16431643
.catch(fail)
16441644
.then(done);
@@ -1671,6 +1671,11 @@ describe('Test gl2d plots', function() {
16711671
expect(gd.layout.xaxis.range).toBeCloseToArray([-8, 24], 3);
16721672
expect(gd.layout.yaxis.range).toBeCloseToArray([0, 16], 3);
16731673

1674+
// no change - too small
1675+
mouseTo([centerX, centerY], [centerX - 5, centerY + 5]);
1676+
expect(gd.layout.xaxis.range).toBeCloseToArray([-8, 24], 3);
1677+
expect(gd.layout.yaxis.range).toBeCloseToArray([0, 16], 3);
1678+
16741679
// now there should only be 2D zooming
16751680
// dy>>dx
16761681
mouseTo([centerX, centerY], [centerX - 1, centerY - 50]);
@@ -1682,11 +1687,6 @@ describe('Test gl2d plots', function() {
16821687
expect(gd.layout.xaxis.range).toBeCloseToArray([4, 6], 3);
16831688
expect(gd.layout.yaxis.range).toBeCloseToArray([9, 10], 3);
16841689

1685-
// no change - too small
1686-
mouseTo([centerX, centerY], [centerX - 5, centerY + 5]);
1687-
expect(gd.layout.xaxis.range).toBeCloseToArray([-8, 24], 3);
1688-
expect(gd.layout.yaxis.range).toBeCloseToArray([0, 16], 3);
1689-
16901690
return Plotly.relayout(gd, {
16911691
'xaxis.autorange': true,
16921692
'yaxis.autorange': true

0 commit comments

Comments
 (0)