more idiomatic D3

monfera · monfera · commit 732bd4634fc2 · 2017-10-03T23:23:38.000+02:00
diff --git a/src/traces/table/plot.js b/src/traces/table/plot.js
@@ -673,8 +673,7 @@ function findPagesAndCacheHeights(blocks, scrollY, scrollHeight) {
 }
 
 function updateBlockYPosition(gd, cellsColumnBlock, tableControlView) {
-    // fixme this function is THE performance hotspot
-    var d = cellsColumnBlock[0][0].__data__;
+    var d = cellsColumnBlock.data()[0];
     var blocks = d.rowBlocks;
     var calcdata = d.calcdata;
 

Original file line number	Diff line number	Diff line change
`@@ -673,8 +673,7 @@ function findPagesAndCacheHeights(blocks, scrollY, scrollHeight) {`
`673`	`673`	`}`
`674`	`674`
`675`	`675`	`function updateBlockYPosition(gd, cellsColumnBlock, tableControlView) {`
`676`		`- // fixme this function is THE performance hotspot`
`677`		`- var d = cellsColumnBlock[0][0].__data__;`
	`676`	`+ var d = cellsColumnBlock.data()[0];`
`678`	`677`	`var blocks = d.rowBlocks;`
`679`	`678`	`var calcdata = d.calcdata;`
`680`	`679`