Skip to content

Commit 74c75ad

Browse files
archmojCoding-with-Adam
authored andcommitted
cherry-pick two commits for plot refactor
1 parent 6b0ddd9 commit 74c75ad

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/traces/icicle/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ module.exports = {
1515
calc: require('./calc').calc,
1616
crossTraceCalc: require('./calc').crossTraceCalc,
1717

18-
plot: require('../treemap/plot'),
18+
plot: require('./plot'),
1919
style: require('./style').style,
2020

2121
colorbar: require('../scatter/marker_colorbar'),

src/traces/treemap/plot.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,12 @@ var helpers = require('../sunburst/helpers');
77
var uniformText = require('../bar/uniform_text');
88
var clearMinTextSize = uniformText.clearMinTextSize;
99
var resizeText = require('../bar/style').resizeText;
10-
var constants = require('./constants');
11-
var drawIcicleGraph = require('../icicle/draw_descendants');
1210
var drawDescendants = require('./draw_descendants');
1311
var plotOne = require('./plot_one');
1412
var type = 'treemap';
1513

1614
module.exports = function _plot(gd, cdmodule, transitionOpts, makeOnCompleteCallback) {
1715
var fullLayout = gd._fullLayout;
18-
var type = cdmodule[0][0].trace.type;
1916
var layer = fullLayout['_' + type + 'layer'];
2017
var join, onComplete;
2118

@@ -69,6 +66,7 @@ module.exports = function _plot(gd, cdmodule, transitionOpts, makeOnCompleteCall
6966
join.exit().remove();
7067
}
7168
};
69+
<<<<<<< HEAD
7270

7371

7472
function getKey(pt) {

0 commit comments

Comments
 (0)