Skip to content

Commit 78d9afa

Browse files
committed
scattermapbox: use eventData hook to add lon[i], lat[i] to event data
1 parent 63ee7f7 commit 78d9afa

File tree

3 files changed

+22
-6
lines changed

3 files changed

+22
-6
lines changed
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
/**
2+
* Copyright 2012-2016, Plotly, Inc.
3+
* All rights reserved.
4+
*
5+
* This source code is licensed under the MIT license found in the
6+
* LICENSE file in the root directory of this source tree.
7+
*/
8+
9+
10+
'use strict';
11+
12+
13+
module.exports = function eventData(out, pt) {
14+
out.lon = pt.lon;
15+
out.lat = pt.lat;
16+
17+
return out;
18+
};

src/traces/scattermapbox/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ ScatterMapbox.supplyDefaults = require('./defaults');
1616
ScatterMapbox.colorbar = require('../scatter/colorbar');
1717
ScatterMapbox.calc = require('./calc');
1818
ScatterMapbox.hoverPoints = require('./hover');
19+
ScatterMapbox.eventData = require('./event_data');
1920
ScatterMapbox.plot = require('./plot');
2021

2122
ScatterMapbox.moduleType = 'trace';

test/jasmine/tests/mapbox_test.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -695,8 +695,7 @@ describe('mapbox plots', function() {
695695
return _mouseEvent('mousemove', pointPos, function() {
696696
expect(hoverData).not.toBe(undefined, 'firing on data points');
697697
expect(Object.keys(hoverData)).toEqual([
698-
'data', 'fullData', 'curveNumber', 'pointNumber',
699-
'x', 'y', 'xaxis', 'yaxis'
698+
'data', 'fullData', 'curveNumber', 'pointNumber', 'lon', 'lat'
700699
], 'returning the correct event data keys');
701700
expect(hoverData.curveNumber).toEqual(0, 'returning the correct curve number');
702701
expect(hoverData.pointNumber).toEqual(0, 'returning the correct point number');
@@ -706,8 +705,7 @@ describe('mapbox plots', function() {
706705
return _mouseEvent('mousemove', blankPos, function() {
707706
expect(unhoverData).not.toBe(undefined, 'firing on data points');
708707
expect(Object.keys(unhoverData)).toEqual([
709-
'data', 'fullData', 'curveNumber', 'pointNumber',
710-
'x', 'y', 'xaxis', 'yaxis'
708+
'data', 'fullData', 'curveNumber', 'pointNumber', 'lon', 'lat'
711709
], 'returning the correct event data keys');
712710
expect(unhoverData.curveNumber).toEqual(0, 'returning the correct curve number');
713711
expect(unhoverData.pointNumber).toEqual(0, 'returning the correct point number');
@@ -804,8 +802,7 @@ describe('mapbox plots', function() {
804802
return _click(pointPos, function() {
805803
expect(ptData).not.toBe(undefined, 'firing on data points');
806804
expect(Object.keys(ptData)).toEqual([
807-
'data', 'fullData', 'curveNumber', 'pointNumber',
808-
'x', 'y', 'xaxis', 'yaxis'
805+
'data', 'fullData', 'curveNumber', 'pointNumber', 'lon', 'lat'
809806
], 'returning the correct event data keys');
810807
expect(ptData.curveNumber).toEqual(0, 'returning the correct curve number');
811808
expect(ptData.pointNumber).toEqual(0, 'returning the correct point number');

0 commit comments

Comments
 (0)