Skip to content

Commit 7b0ab24

Browse files
committed
run mathjax v2 and v3 in the same container
1 parent 63e240e commit 7b0ab24

File tree

2 files changed

+15
-67
lines changed

2 files changed

+15
-67
lines changed

.circleci/config.yml

Lines changed: 12 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ jobs:
160160
name: Run jasmine tests (part D)
161161
command: .circleci/test.sh bundle-jasmine
162162

163-
mathjax-v2-firefox81:
163+
mathjax-firefox81:
164164
docker:
165165
# need '-browsers' version to test in real (xvfb-wrapped) browsers
166166
- image: cimg/node:16.8.0-browsers
@@ -176,10 +176,10 @@ jobs:
176176
- attach_workspace:
177177
at: ~/
178178
- run:
179-
name: Test MathJax v2 on firefox-81
180-
command: .circleci/test.sh mathjax-v2-firefox
179+
name: Test MathJax on firefox-81
180+
command: .circleci/test.sh mathjax-firefox
181181

182-
mathjax-v2-firefox82:
182+
mathjax-firefox82:
183183
docker:
184184
# need '-browsers' version to test in real (xvfb-wrapped) browsers
185185
- image: cimg/node:16.8.0-browsers
@@ -195,10 +195,10 @@ jobs:
195195
- attach_workspace:
196196
at: ~/
197197
- run:
198-
name: Test MathJax v2 on firefox-82
199-
command: .circleci/test.sh mathjax-v2-firefox82+
198+
name: Test MathJax on firefox-82
199+
command: .circleci/test.sh mathjax-firefox82+
200200

201-
mathjax-v2-firefoxLatest:
201+
mathjax-firefoxLatest:
202202
docker:
203203
# need '-browsers' version to test in real (xvfb-wrapped) browsers
204204
- image: cimg/node:16.8.0-browsers
@@ -213,45 +213,8 @@ jobs:
213213
- attach_workspace:
214214
at: ~/
215215
- run:
216-
name: Test MathJax v2 on firefox-latest
217-
command: .circleci/test.sh mathjax-v2-firefox82+
218-
219-
mathjax-v3-firefoxLatest:
220-
docker:
221-
# need '-browsers' version to test in real (xvfb-wrapped) browsers
222-
- image: cimg/node:16.8.0-browsers
223-
environment:
224-
# Alaska time (arbitrary timezone to test date logic)
225-
TZ: "America/Anchorage"
226-
working_directory: ~/plotly.js
227-
steps:
228-
- browser-tools/install-browser-tools: &browser-versions
229-
install-chrome: false
230-
install-chromedriver: false
231-
- attach_workspace:
232-
at: ~/
233-
- run:
234-
name: Test MathJax v3 on firefox-latest
235-
command: .circleci/test.sh mathjax-v3-firefox82+
236-
237-
mathjax-v3-firefox81:
238-
docker:
239-
# need '-browsers' version to test in real (xvfb-wrapped) browsers
240-
- image: cimg/node:16.8.0-browsers
241-
environment:
242-
# Alaska time (arbitrary timezone to test date logic)
243-
TZ: "America/Anchorage"
244-
working_directory: ~/plotly.js
245-
steps:
246-
- browser-tools/install-browser-tools: &browser-versions
247-
firefox-version: '81.0'
248-
install-chrome: false
249-
install-chromedriver: false
250-
- attach_workspace:
251-
at: ~/
252-
- run:
253-
name: Test MathJax v2 on firefox-81
254-
command: .circleci/test.sh mathjax-v3-firefox
216+
name: Test MathJax on firefox-latest
217+
command: .circleci/test.sh mathjax-firefox82+
255218

256219
make-baselines:
257220
parallelism: 4
@@ -432,19 +395,13 @@ workflows:
432395
- bundle-jasmine:
433396
requires:
434397
- install-and-cibuild
435-
- mathjax-v2-firefox81:
436-
requires:
437-
- install-and-cibuild
438-
- mathjax-v2-firefox82:
439-
requires:
440-
- install-and-cibuild
441-
- mathjax-v2-firefoxLatest:
398+
- mathjax-firefox81:
442399
requires:
443400
- install-and-cibuild
444-
- mathjax-v3-firefoxLatest:
401+
- mathjax-firefox82:
445402
requires:
446403
- install-and-cibuild
447-
- mathjax-v3-firefox81:
404+
- mathjax-firefoxLatest:
448405
requires:
449406
- install-and-cibuild
450407
- no-gl-jasmine:

.circleci/test.sh

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -69,26 +69,17 @@ case $1 in
6969
exit $EXIT_STATE
7070
;;
7171

72-
mathjax-v2-firefox)
72+
mathjax-firefox)
7373
./node_modules/karma/bin/karma start test/jasmine/karma.conf.js --FF --bundleTest=mathjax_v2 --nowatch || EXIT_STATE=$?
7474
exit $EXIT_STATE
7575
;;
7676

77-
mathjax-v2-firefox82+)
78-
./node_modules/karma/bin/karma start test/jasmine/karma.conf.js --FF --skip-tags=noFF82 --bundleTest=mathjax_v2 --nowatch || EXIT_STATE=$?
79-
exit $EXIT_STATE
80-
;;
81-
82-
mathjax-v3-firefox82+)
77+
mathjax-firefox82+)
78+
./node_modules/karma/bin/karma start test/jasmine/karma.conf.js --FF --skip-tags=noFF82 --bundleTest=mathjax_v2 --nowatch &&
8379
./node_modules/karma/bin/karma start test/jasmine/karma.conf.js --FF --skip-tags=noFF82 --bundleTest=mathjax_v3 --nowatch || EXIT_STATE=$?
8480
exit $EXIT_STATE
8581
;;
8682

87-
mathjax-v3-firefox)
88-
./node_modules/karma/bin/karma start test/jasmine/karma.conf.js --FF --bundleTest=mathjax_v3 --nowatch || EXIT_STATE=$?
89-
exit $EXIT_STATE
90-
;;
91-
9283
make-baselines)
9384
SUITE=$(find $ROOT/test/image/mocks/ -type f -printf "%f\n" | sed 's/\.json$//1' | circleci tests split)
9485
python3 test/image/make_baseline.py $SUITE || EXIT_STATE=$?

0 commit comments

Comments
 (0)