correct icicle and treemap plots without cd

Author: archmoj

src/traces/icicle/index.js

@@ -15,7 +15,7 @@ module.exports = {
     calc: require('./calc').calc,
     crossTraceCalc: require('./calc').crossTraceCalc,
 
-    plot: require('../treemap/plot'),
+    plot: require('./plot'),
     style: require('./style').style,
 
     colorbar: require('../scatter/marker_colorbar'),

src/traces/icicle/plot.js

@@ -0,0 +1,68 @@
+'use strict';
+
+var d3 = require('@plotly/d3');
+
+var helpers = require('../sunburst/helpers');
+
+var uniformText = require('../bar/uniform_text');
+var clearMinTextSize = uniformText.clearMinTextSize;
+var resizeText = require('../bar/style').resizeText;
+var drawDescendants = require('./draw_descendants');
+var plotOne = require('../treemap/plot_one');
+var type = 'icicle';
+
+module.exports = function _plot(gd, cdmodule, transitionOpts, makeOnCompleteCallback) {
+    var fullLayout = gd._fullLayout;
+    var layer = fullLayout['_' + type + 'layer'];
+    var join, onComplete;
+
+    // If transition config is provided, then it is only a partial replot and traces not
+    // updated are removed.
+    var isFullReplot = !transitionOpts;
+
+    clearMinTextSize(type, fullLayout);
+
+    join = layer.selectAll('g.trace.' + type)
+        .data(cdmodule, function(cd) { return cd[0].trace.uid; });
+
+    join.enter().append('g')
+        .classed('trace', true)
+        .classed(type, true);
+
+    join.order();
+
+    if(!fullLayout.uniformtext.mode && helpers.hasTransition(transitionOpts)) {
+        if(makeOnCompleteCallback) {
+            // If it was passed a callback to register completion, make a callback. If
+            // this is created, then it must be executed on completion, otherwise the
+            // pos-transition redraw will not execute:
+            onComplete = makeOnCompleteCallback();
+        }
+
+        var transition = d3.transition()
+            .duration(transitionOpts.duration)
+            .ease(transitionOpts.easing)
+            .each('end', function() { onComplete && onComplete(); })
+            .each('interrupt', function() { onComplete && onComplete(); });
+
+        transition.each(function() {
+            // Must run the selection again since otherwise enters/updates get grouped together
+            // and these get executed out of order. Except we need them in order!
+            layer.selectAll('g.trace').each(function(cd) {
+                plotOne(gd, cd, this, transitionOpts, drawDescendants);
+            });
+        });
+    } else {
+        join.each(function(cd) {
+            plotOne(gd, cd, this, transitionOpts, drawDescendants);
+        });
+
+        if(fullLayout.uniformtext.mode) {
+            resizeText(gd, layer.selectAll('.trace'), type);
+        }
+    }
+
+    if(isFullReplot) {
+        join.exit().remove();
+    }
+};