Skip to content

Commit 83234b5

Browse files
committed
[breaking] add join.order() calls during marker and text node updates
- this reorders the object-constant nodes (i.e. for traces w/ ids) correctly 🎉 - BUT, this also brakes the update pattern for traces with non-numeric (x,y), as the .remove call in Drawing.translatePoint throws the join selections out-of-sync, leading an exception!
1 parent cbcec26 commit 83234b5

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/traces/scatter/plot.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -444,6 +444,8 @@ function plotOne(gd, idx, plotinfo, cdscatter, cdscatterAll, element, transition
444444
}
445445
});
446446

447+
join.order();
448+
447449
if(hasTransition) {
448450
join.exit().transition()
449451
.style('opacity', 0)
@@ -483,6 +485,8 @@ function plotOne(gd, idx, plotinfo, cdscatter, cdscatterAll, element, transition
483485
});
484486
});
485487

488+
join.order();
489+
486490
join.exit().remove();
487491
}
488492

0 commit comments

Comments
 (0)