fixes for reversed bounds in 3d scenes

Author: archmoj

package-lock.json

@@ -70,21 +70,21 @@
     "es6-promise": "^3.0.2",
     "fast-isnumeric": "^1.1.1",
     "font-atlas-sdf": "^1.3.3",
-    "gl-cone3d": "^1.1.0",
+    "gl-cone3d": "git://github.com/archmoj/gl-cone3d.git#823cabfbb19d8b457730320010cb58df748ff9ee",
     "gl-contour2d": "^1.1.4",
-    "gl-error3d": "^1.0.7",
+    "gl-error3d": "git://github.com/archmoj/gl-error3d.git#d09c224fe25671fcd588a8c803fe83129156fbab",
     "gl-heatmap2d": "^1.0.4",
-    "gl-line3d": "^1.1.2",
+    "gl-line3d": "git://github.com/archmoj/gl-line3d.git#681398a5477f64cfd92ff7494215d5b6854e834b",
     "gl-mat4": "^1.2.0",
-    "gl-mesh3d": "^2.0.0",
+    "gl-mesh3d": "git://github.com/archmoj/gl-mesh3d.git#5828f6255d8c5360631d5feec65801bb104a88e8",
     "gl-plot2d": "^1.3.1",
     "gl-plot3d": "^1.5.5",
     "gl-pointcloud2d": "^1.0.1",
-    "gl-scatter3d": "^1.0.11",
+    "gl-scatter3d": "git://github.com/archmoj/gl-scatter3d.git#b649f8fb619242525b64ccf1def62cb2ed3f224f",
     "gl-select-box": "^1.0.2",
     "gl-spikes2d": "^1.0.1",
-    "gl-streamtube3d": "^1.0.0",
-    "gl-surface3d": "^1.3.5",
+    "gl-streamtube3d": "git://github.com/archmoj/gl-streamtube3d.git#f4f5a63ffb19704a1ab1cadcc7aa848d7b68f7bf",
+    "gl-surface3d": "git://github.com/archmoj/gl-surface3d.git#2455aad56d3727b940fad8d02727806abca0fdf4",
     "gl-text": "^1.1.6",
     "glslify": "^6.3.1",
     "has-hover": "^1.0.1",

package.json

@@ -41,7 +41,7 @@ function render(scene) {
     svgContainer.setAttributeNS(null, 'viewBox', '0 0 ' + width + ' ' + height);
     svgContainer.setAttributeNS(null, 'width', width);
     svgContainer.setAttributeNS(null, 'height', height);
-
+    
     computeTickMarks(scene);
     scene.glplot.axes.update(scene.axesOptions);
 
@@ -383,6 +383,13 @@ function computeTraceBounds(scene, trace, bounds) {
     }
 }
 
+function isCloseToZero (a) {
+    if (Math.abs(a) > Number.MIN_VALUE) { // the smallest positive numeric value representable in JavaScript
+        return false;
+    }
+    return true;
+}
+
 proto.plot = function(sceneData, fullLayout, layout) {
 
     // Save parameters
@@ -399,7 +406,7 @@ proto.plot = function(sceneData, fullLayout, layout) {
     else this.glplot.clearColor = [0, 0, 0, 0];
 
     this.glplot.snapToData = true;
-
+    
     // Update layout
     this.fullLayout = fullLayout;
     this.fullSceneLayout = fullSceneLayout;
@@ -421,7 +428,7 @@ proto.plot = function(sceneData, fullLayout, layout) {
     // Convert scene data
     if(!sceneData) sceneData = [];
     else if(!Array.isArray(sceneData)) sceneData = [sceneData];
-
+    
     // Compute trace bounding box
     var dataBounds = [
         [Infinity, Infinity, Infinity],
@@ -435,19 +442,10 @@ proto.plot = function(sceneData, fullLayout, layout) {
     }
     var dataScale = [1, 1, 1];
     for(j = 0; j < 3; ++j) {
-        if(dataBounds[0][j] > dataBounds[1][j]) {
-            dataScale[j] = 1.0;
-        }
-        else {
-            if(dataBounds[1][j] === dataBounds[0][j]) {
-                dataScale[j] = 1.0;
-            }
-            else {
-                dataScale[j] = 1.0 / (dataBounds[1][j] - dataBounds[0][j]);
-            }
-        }
+        var diff = dataBounds[1][j] - dataBounds[0][j];
+        if(!isCloseToZero(diff)) dataScale[j] = 1.0 / diff;
     }
-
+    
     // Save scale
     this.dataScale = dataScale;
 
@@ -558,7 +556,14 @@ proto.plot = function(sceneData, fullLayout, layout) {
             } else {
                 var d = sceneBounds[1][i] - sceneBounds[0][i];
                 sceneBounds[0][i] -= d / 32.0;
-                sceneBounds[1][i] += d / 32.0;
+                sceneBounds[1][i] += d / 32.0;            
+            }
+            
+            if(axis.autorange === 'reversed') {
+                // swap bounds: 
+                var tmp = sceneBounds[0][i];
+                sceneBounds[0][i] = sceneBounds[1][i];
+                sceneBounds[1][i] = tmp;
             }
         } else {
             var range = axis.range;
@@ -570,14 +575,14 @@ proto.plot = function(sceneData, fullLayout, layout) {
             sceneBounds[1][i] += 1;
         }
         axisDataRange[i] = sceneBounds[1][i] - sceneBounds[0][i];
-
+        
         // Update plot bounds
         this.glplot.bounds[0][i] = sceneBounds[0][i] * dataScale[i];
         this.glplot.bounds[1][i] = sceneBounds[1][i] * dataScale[i];
     }
-
+    
     var axesScaleRatio = [1, 1, 1];
-
+    
     // Compute axis scale per category
     for(i = 0; i < 3; ++i) {
         axis = fullSceneLayout[axisProperties[i]];