Skip to content

Commit 94202e0

Browse files
committed
fix issue 5314
- reduce minfinalheight to 16 - revert jasmine tests to what we had before commit 565f942
1 parent fa781ed commit 94202e0

File tree

5 files changed

+3
-3
lines changed

5 files changed

+3
-3
lines changed

src/plots/plots.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1867,7 +1867,7 @@ function initMargins(fullLayout) {
18671867
}
18681868

18691869
var minFinalWidth = 64; // could possibly be exposed as layout.margin.minfinalwidth
1870-
var minFinalHeight = 64; // could possibly be exposed as layout.margin.minfinalheight
1870+
var minFinalHeight = 16; // could possibly be exposed as layout.margin.minfinalheight
18711871

18721872
/**
18731873
* autoMargin: called by components that may need to expand the margins to
-354 Bytes
Loading
-670 Bytes
Loading

test/jasmine/tests/indicator_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ describe('Indicator plot', function() {
170170
return Plotly.relayout(gd, {width: 200, height: 200});
171171
})
172172
.then(function() {
173-
checkNumbersScale(0.4794007490636704, 'should scale down');
173+
checkNumbersScale(0.2, 'should scale down');
174174
return Plotly.relayout(gd, {width: 400, height: 400});
175175
})
176176
.then(function() {

test/jasmine/tests/legend_scroll_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,7 @@ describe('The legend', function() {
403403
expect(countLegendClipPaths(gd)).toBe(1);
404404

405405
// clippath resized to new height less than new plot height
406-
expect(+legendHeight).toBeGreaterThan(getPlotHeight(gd));
406+
expect(+legendHeight).toBe(getPlotHeight(gd));
407407
expect(+legendHeight).toBeLessThan(+origLegendHeight);
408408

409409
done();

0 commit comments

Comments
 (0)