Skip to content

Commit 9b0be90

Browse files
committed
handle typed arrays in scattergeo locations
1 parent 4bab8de commit 9b0be90

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/traces/scattergeo/calc.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ var BADNUM = require('../../constants/numerical').BADNUM;
66
var calcMarkerColorscale = require('../scatter/colorscale_calc');
77
var arraysToCalcdata = require('../scatter/arrays_to_calcdata');
88
var calcSelection = require('../scatter/calc_selection');
9+
var isArrayOrTypedArray = require('../../lib').isArrayOrTypedArray;
910

1011
var _ = require('../../lib')._;
1112

@@ -14,7 +15,7 @@ function isNonBlankString(v) {
1415
}
1516

1617
module.exports = function calc(gd, trace) {
17-
var hasLocationData = Array.isArray(trace.locations);
18+
var hasLocationData = isArrayOrTypedArray(trace.locations);
1819
var len = hasLocationData ? trace.locations.length : trace._length;
1920
var calcTrace = new Array(len);
2021

src/traces/scattergeo/plot.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ function calcGeoJSON(calcTrace, fullLayout) {
7272
var len = trace._length;
7373
var i, calcPt;
7474

75-
if(Array.isArray(trace.locations)) {
75+
if(Lib.isArrayOrTypedArray(trace.locations)) {
7676
var locationmode = trace.locationmode;
7777
var features = locationmode === 'geojson-id' ?
7878
geoUtils.extractTraceFeature(calcTrace) :

0 commit comments

Comments
 (0)