Skip to content

Commit 9bb0c53

Browse files
committed
remove now unused empty plot container
1 parent c805713 commit 9bb0c53

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/plots/cartesian/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,6 @@ function makeSubplotLayer(gd, plotinfo) {
507507
ensureSingle(plotgroup, 'g', 'yaxislayer-below');
508508
plotinfo.overaxesBelow = ensureSingle(plotgroup, 'g', 'overaxes-below');
509509

510-
ensureSingle(plotgroup, 'g', 'plot');
511510
plotinfo.overplot = ensureSingle(plotgroup, 'g', 'overplot');
512511
plotinfo.plot = ensureSingle(plotinfo.overplot, 'g', id);
513512

test/jasmine/tests/splom_test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -825,7 +825,7 @@ describe('Test splom interactions:', function() {
825825
.then(function() {
826826
_assert({
827827
subplotCnt: 25,
828-
innerSubplotNodeCnt: 19,
828+
innerSubplotNodeCnt: 18,
829829
hasSplomGrid: false,
830830
bgCnt: 0
831831
});
@@ -845,7 +845,7 @@ describe('Test splom interactions:', function() {
845845
// grid layer would be above xaxis layer,
846846
// if we didn't clear subplot children.
847847
expect(gridIndex).toBe(2, '<g.gridlayer> index');
848-
expect(xaxisIndex).toBe(16, '<g.xaxislayer-above> index');
848+
expect(xaxisIndex).toBe(15, '<g.xaxislayer-above> index');
849849

850850
return Plotly.restyle(gd, 'dimensions', [dimsLarge]);
851851
})
@@ -857,7 +857,7 @@ describe('Test splom interactions:', function() {
857857
// new subplots though have reduced number of children.
858858
innerSubplotNodeCnt: function(d) {
859859
var p = d.match(SUBPLOT_PATTERN);
860-
return (p[1] > 5 || p[2] > 5) ? 4 : 19;
860+
return (p[1] > 5 || p[2] > 5) ? 4 : 18;
861861
},
862862
hasSplomGrid: true,
863863
bgCnt: 0

0 commit comments

Comments
 (0)