Skip to content

Commit 9dcbc71

Browse files
author
Tom Aerts
committed
doubleClickDelay from layout object => config
1 parent 6fd2894 commit 9dcbc71

File tree

4 files changed

+16
-10
lines changed

4 files changed

+16
-10
lines changed

src/components/dragelement/index.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,8 @@ dragElement.unhoverRaw = unhover.raw;
8282
dragElement.init = function init(options) {
8383
var gd = options.gd;
8484
var numClicks = 1;
85-
var DBLCLICKDELAY = interactConstants.DBLCLICKDELAY;
86-
if(options.gd.layout.doubleClickDelay) {
87-
DBLCLICKDELAY = options.gd.layout.doubleClickDelay;
88-
}
85+
var DBLCLICKDELAY = gd._context.doubleClickDelay ? gd._context.doubleClickDelay : interactConstants.DBLCLICKDELAY;
86+
8987
var element = options.element;
9088

9189
var startX,

src/components/legend/draw.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,8 @@ var DBLCLICKDELAY = interactConstants.DBLCLICKDELAY;
3636
module.exports = function draw(gd) {
3737
var fullLayout = gd._fullLayout;
3838
var clipId = 'legend' + fullLayout._uid;
39-
40-
if(gd.layout.doubleClickDelay) {
41-
DBLCLICKDELAY = gd.layout.doubleClickDelay;
42-
}
39+
console.log(gd);
40+
DBLCLICKDELAY = gd._context.doubleClickDelay ? gd._context.doubleClickDelay : DBLCLICKDELAY;
4341

4442
if(!fullLayout._infolayer || !gd.calcdata) return;
4543

@@ -362,6 +360,7 @@ module.exports = function draw(gd) {
362360

363361
function clickOrDoubleClick(gd, legend, legendItem, numClicks, evt) {
364362
var trace = legendItem.data()[0][0].trace;
363+
365364
var evtData = {
366365
event: evt,
367366
node: legendItem.node(),

src/plot_api/plot_config.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,15 @@ var configAttributes = {
172172
'to their autorange values.'
173173
].join(' ')
174174
},
175+
doubleClickDelay: {
176+
valType: 'number',
177+
dflt: 300,
178+
min: 0,
179+
max: 1000,
180+
description: [
181+
'Sets the delay for registering a doubleclick in ms'
182+
].join(' ')
183+
},
175184

176185
showAxisDragHandles: {
177186
valType: 'boolean',

src/plots/layout_attributes.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ module.exports = {
432432
].join(' '),
433433
editType: 'none'
434434
}),
435-
doubleClickDelay: {
435+
/*doubleClickDelay: {
436436
valType: 'number',
437437
min: 0,
438438
max: 1000,
@@ -441,7 +441,7 @@ module.exports = {
441441
description: [
442442
'Sets the delay for registering a doubleclick in ms'
443443
].join(' ')
444-
},
444+
},*/
445445
_deprecated: {
446446
title: {
447447
valType: 'string',

0 commit comments

Comments
 (0)