Skip to content

Commit a859456

Browse files
committed
bump to node8/npm5 -> update circleci config
- use official '8.9.4' docker images - checksum package-lock.json to check cache - replace (now unnecessary) install/dedupe/prune/install with a simple install (now with package-lock.json this does the right thing everytime ;)
1 parent 8b906cb commit a859456

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

.circleci/config.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,25 +3,25 @@ version: 2.0
33
# Inspired by:
44
# https://github.com/CircleCI-Public/circleci-demo-workflows/blob/workspace-forwarding/.circleci/config.yml
55
# https://circleci.com/docs/2.0/workflows/#using-workspaces-to-share-data-among-jobs
6+
#
7+
# For list of official CircleCI node.js images, go to:
8+
# https://hub.docker.com/r/circleci/node/tags/
69

710
jobs:
811
build:
912
docker:
10-
- image: circleci/node:6.10.3
13+
- image: circleci/node:8.9.4
1114
working_directory: ~/plotly.js
1215
steps:
1316
- checkout
1417
- restore_cache:
1518
keys:
16-
- v{{ .Environment.CIRCLE_CACHE_VERSION }}-deps-{{ .Branch }}-{{ checksum "package.json" }}
17-
- v{{ .Environment.CIRCLE_CACHE_VERSION }}-deps-master-{{ checksum "package.json" }}
19+
- v{{ .Environment.CIRCLE_CACHE_VERSION }}-deps-{{ .Branch }}-{{ checksum "package-lock.json" }}
20+
- v{{ .Environment.CIRCLE_CACHE_VERSION }}-deps-master-{{ checksum "package-lock.json" }}
1821
- run:
1922
name: Install dependencies
2023
command: |
2124
npm install
22-
npm dedupe
23-
npm prune
24-
npm install
2525
- run:
2626
name: List dependency versions
2727
command: |
@@ -47,7 +47,7 @@ jobs:
4747
test-jasmine:
4848
docker:
4949
# need '-browsers' version to test in real (xvfb-wrapped) browsers
50-
- image: circleci/node:6.10.3-browsers
50+
- image: circleci/node:8.9.4-browsers
5151
working_directory: ~/plotly.js
5252
steps:
5353
- checkout
@@ -82,7 +82,7 @@ jobs:
8282

8383
test-syntax:
8484
docker:
85-
- image: circleci/node:6.10.3
85+
- image: circleci/node:8.9.4
8686
working_directory: ~/plotly.js
8787
steps:
8888
- checkout

0 commit comments

Comments
 (0)