Skip to content

Commit b07aa6a

Browse files
committed
fixup test
1 parent ea92715 commit b07aa6a

File tree

3 files changed

+40
-48
lines changed

3 files changed

+40
-48
lines changed

src/traces/isosurface/fn_generate-iso-meshes.js

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -712,6 +712,33 @@ var generateIsoMeshes = function(data) {
712712

713713
var activeStyle = null;
714714

715+
// draw spaceframes
716+
if(showSpaceframe && spaceframeFill) {
717+
setFill(spaceframeFill);
718+
719+
drawSpaceframe(activeStyle, vMin, vMax);
720+
}
721+
722+
// draw iso-surfaces
723+
if(showSurface && surfaceFill) {
724+
setFill(surfaceFill);
725+
726+
var surfacePattern = data.surface.pattern;
727+
var surfaceCount = data.surface.count;
728+
for(var q = 0; q < surfaceCount; q++) {
729+
var ratio = (surfaceCount === 1) ? 0.5 : q / (surfaceCount - 1);
730+
var level = (1 - ratio) * vMin + ratio * vMax;
731+
732+
var d1 = Math.abs(level - minValues);
733+
var d2 = Math.abs(level - maxValues);
734+
var ranges = (d1 > d2) ?
735+
[minValues, level] :
736+
[level, maxValues];
737+
738+
drawSurface(surfacePattern, ranges[0], ranges[1]);
739+
}
740+
}
741+
715742
var setupMinMax = [
716743
[ Math.min(vMin, maxValues), Math.max(vMin, maxValues) ],
717744
[ Math.min(minValues, vMax), Math.max(minValues, vMax) ]
@@ -802,33 +829,6 @@ var generateIsoMeshes = function(data) {
802829
}
803830
});
804831

805-
// draw spaceframes
806-
if(showSpaceframe && spaceframeFill) {
807-
setFill(spaceframeFill);
808-
809-
drawSpaceframe(activeStyle, vMin, vMax);
810-
}
811-
812-
// draw iso-surfaces
813-
if(showSurface && surfaceFill) {
814-
setFill(surfaceFill);
815-
816-
var surfacePattern = data.surface.pattern;
817-
var surfaceCount = data.surface.count;
818-
for(var q = 0; q < surfaceCount; q++) {
819-
var ratio = (surfaceCount === 1) ? 0.5 : q / (surfaceCount - 1);
820-
var level = (1 - ratio) * vMin + ratio * vMax;
821-
822-
var d1 = Math.abs(level - minValues);
823-
var d2 = Math.abs(level - maxValues);
824-
var ranges = (d1 > d2) ?
825-
[minValues, level] :
826-
[level, maxValues];
827-
828-
drawSurface(surfacePattern, ranges[0], ranges[1]);
829-
}
830-
}
831-
832832
// remove vertices arrays (i.e. grid points) in case no face was created.
833833
if(numFaces === 0) {
834834
emptyVertices();

test/image/compare_pixels_test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,8 @@ function untestableFilter(mockName) {
9797
mockName === 'font-wishlist' ||
9898
mockName.indexOf('gl2d_') !== -1 ||
9999
mockName.indexOf('mapbox_') !== -1 ||
100-
mockName.indexOf('gl3d_cone-') !== -1
100+
mockName.indexOf('gl3d_cone-') !== -1 ||
101+
mockName.indexOf('gl3d_volume_mri') !== -1
101102
);
102103

103104
if(!cond) console.log(' -', mockName);

test/image/mocks/gl3d_volume_mri.json

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,16 @@
11
{
22
"data": [{
33
"type": "volume",
4-
"colorscale": [[ 0.0, "rgb(255,255,255)" ], [ 0.15, "rgb(255,255,0)" ], [ 0.3, "rgb(255,0,0)" ], [ 1.0, "rgb(0,0,0)" ]],
4+
"colorscale": [[ 0.0, "rgb(255,255,255)" ], [ 0.125, "rgb(255,255,0)" ], [ 0.200, "rgb(255,0,0)" ], [ 0.275, "rgb(0,0,0)" ], [ 1.0, "rgb(255,255,255)" ]],
55
"reversescale": false,
6-
"opacityscale": false,
7-
"opacity": 0.03,
8-
"surface": { "show": true, "fill": 1.0, "count": 11 },
9-
"spaceframe": { "show": true, "fill": 1.0 },
6+
"opacityscale": [[ 0.0, 0.0 ], [ 0.125, 0.1 ], [ 0.200, 1.0 ], [ 0.275, 1.0 ], [ 1.0, 0.0 ]],
7+
"opacity": 0.04,
8+
"surface": { "show": true, "fill": 1.0, "count": 9 },
9+
"spaceframe": { "show": false, "fill": 1.0 },
1010
"slices": {
11-
"x": { "show": false, "fill": 1.0 },
12-
"y": { "show": false, "fill": 1.0 },
13-
"z": { "show": false, "fill": 1.0 }
14-
},
15-
"caps": {
16-
"x": { "show": false, "fill": 1.0 },
17-
"y": { "show": false, "fill": 1.0 },
18-
"z": { "show": false, "fill": 1.0 }
19-
},
20-
"contour": {
21-
"show": false,
22-
"width": 4
11+
"x": { "show": true, "fill": 1.0 },
12+
"y": { "show": true, "fill": 1.0 },
13+
"z": { "show": true, "fill": 1.0 }
2314
},
2415
"isomin": null,
2516
"isomax": null,
@@ -11049,9 +11040,9 @@
1104911040
"zaxis": { "nticks": 12, "autorange": "reversed" },
1105011041
"camera": {
1105111042
"eye": {
11052-
"x": 1.5,
11053-
"y": -0.25,
11054-
"z": -0.5
11043+
"x": -1.5,
11044+
"y": -0.75,
11045+
"z": 0.25
1105511046
},
1105611047
"center": {
1105711048
"x": 0,

0 commit comments

Comments
 (0)