Skip to content

Commit c7f0e10

Browse files
committed
handle typed arrays in parcoords
1 parent 590ce4f commit c7f0e10

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/traces/parcoords/parcoords.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
var d3 = require('@plotly/d3');
44
var Lib = require('../../lib');
5+
var isArrayOrTypedArray = Lib.isArrayOrTypedArray;
56
var numberFormat = Lib.numberFormat;
67
var rgba = require('color-rgba');
78

@@ -237,7 +238,7 @@ function viewModel(state, callbacks, model) {
237238
var key = dimension.label + (foundKey ? '__' + foundKey : '');
238239
var specifiedConstraint = dimension.constraintrange;
239240
var filterRangeSpecified = specifiedConstraint && specifiedConstraint.length;
240-
if(filterRangeSpecified && !Array.isArray(specifiedConstraint[0])) {
241+
if(filterRangeSpecified && !isArrayOrTypedArray(specifiedConstraint[0])) {
241242
specifiedConstraint = [specifiedConstraint];
242243
}
243244
var filterRange = filterRangeSpecified ?
@@ -265,11 +266,13 @@ function viewModel(state, callbacks, model) {
265266
var ticktext;
266267
function makeTickItem(v, i) { return {val: v, text: ticktext[i]}; }
267268
function sortTickItem(a, b) { return a.val - b.val; }
268-
if(Array.isArray(tickvals) && tickvals.length) {
269+
if(isArrayOrTypedArray(tickvals) && tickvals.length) {
270+
if(Lib.isTypedArray(tickvals)) tickvals = Array.from(tickvals);
271+
269272
ticktext = dimension.ticktext;
270273

271274
// ensure ticktext and tickvals have same length
272-
if(!Array.isArray(ticktext) || !ticktext.length) {
275+
if(!isArrayOrTypedArray(ticktext) || !ticktext.length) {
273276
ticktext = tickvals.map(numberFormat(dimension.tickformat));
274277
} else if(ticktext.length > tickvals.length) {
275278
ticktext = ticktext.slice(0, tickvals.length);

0 commit comments

Comments
 (0)