bring back amdefine test

archmoj · archmoj · commit d74aee542f2b · 2024-03-08T14:14:47.000-05:00
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -470,6 +470,9 @@ jobs:
       - run:
           name: Test plot-schema.json diff - If failed, after (npm start) you could run (npm run schema && git add test/plot-schema.json && git commit -m "update plot-schema diff")
           command: diff --unified --color dist/plot-schema.json test/plot-schema.json
+      - run:
+          name: Test plotly.min.js import using amdefine
+          command: npm run test-amdefine
       - run:
           name: Test plotly bundles against es6
           command: npm run no-es6-dist
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -51,7 +51,8 @@
     "test-export": "node test/image/export_test.js",
     "test-syntax": "node tasks/test_syntax.js && npm run find-strings -- --no-output",
     "test-bundle": "node tasks/test_bundle.js",
-    "test-requirejs": "node tasks/test_requirejs.mjs",
+    "test-amdefine": "node tasks/test_amdefine.js",
+    "test-requirejs": "node tasks/test_requirejs.js",
     "test-plain-obj": "node tasks/test_plain_obj.mjs",
     "test": "npm run test-jasmine -- --nowatch && npm run test-bundle && npm run test-image && npm run test-export && npm run test-syntax && npm run lint",
     "b64": "python3 test/image/generate_b64_mocks.py && node devtools/test_dashboard/server.mjs",
@@ -124,6 +125,7 @@
     "world-calendars": "^1.0.3"
   },
   "devDependencies": {
+    "amdefine": "^1.0.1",
     "assert": "^2.1.0",
     "babel-loader": "^9.1.3",
     "browserify-transform-tools": "^1.7.0",
diff --git a/tasks/test_amdefine.js b/tasks/test_amdefine.js
@@ -0,0 +1,28 @@
+var JSDOM = require('jsdom').JSDOM;
+global.document = new JSDOM('<!DOCTYPE html><head></head><html><body></body></html>').window.document;
+global.window = document.defaultView;
+global.window.document = global.document;
+global.self = global.window;
+global.Blob = global.window.Blob;
+global.DOMParser = global.window.DOMParser;
+global.getComputedStyle = global.window.getComputedStyle;
+global.window.URL.createObjectURL = function() {};
+
+// see: Building node modules with AMD or RequireJS https://requirejs.org/docs/node.html
+if(typeof define !== 'function') {
+    var define = require('amdefine')(module);
+}
+
+define(function(require) {
+    var plotly = require('../dist/plotly.min.js');
+
+    if(plotly && plotly.PlotSchema) {
+        console.log(plotly);
+    } else {
+        throw 'Error: loading with amdefine';
+    }
+
+    // The value returned from the function is
+    // used as the module export visible to Node.
+    return function() {};
+});
diff --git a/tasks/test_requirejs.js b/tasks/test_requirejs.js
@@ -1,4 +1,4 @@
-import { JSDOM  } from 'jsdom';
+var JSDOM = require('jsdom').JSDOM;
 global.document = new JSDOM('<!DOCTYPE html><head></head><html><body></body></html>').window.document;
 global.window = document.defaultView;
 global.window.document = global.document;
@@ -8,7 +8,7 @@ global.DOMParser = global.window.DOMParser;
 global.getComputedStyle = global.window.getComputedStyle;
 global.window.URL.createObjectURL = function() {};
 
-import requirejs from 'requirejs';
+var requirejs = require('requirejs');
 
 requirejs.config({
     paths: {
