Merge pull request #7513 from Lexachoc/fix_title_text_edit_regression_v3.0.0

fix: title text cannot be edited for multiple plots/components (regression since v3.0.0)

Author: emilykl

draftlogs/7513_fix.md

@@ -0,0 +1 @@
+Fix editable `title.text` for `ternary`, `polar`, `colorbar`, and `rangeslider` (regression introduced in 3.0.0) [[#7513](https://github.com/plotly/plotly.js/pull/7513)]

src/components/colorbar/draw.js

@@ -326,7 +326,7 @@ function drawColorBar(g, opts, gd) {
     function drawTitle(titleClass, titleOpts) {
         var dfltTitleOpts = {
             propContainer: ax,
-            propName: opts._propPrefix + 'title',
+            propName: opts._propPrefix + 'title.text',
             traceIndex: opts._traceIndex,
             _meta: opts._meta,
             placeholder: fullLayout._dfltTitle.colorbar,

src/components/rangeslider/draw.js

@@ -212,7 +212,7 @@ module.exports = function(gd) {
         if(axisOpts.side === 'bottom') {
             Titles.draw(gd, axisOpts._id + 'title', {
                 propContainer: axisOpts,
-                propName: axisOpts._name + '.title',
+                propName: axisOpts._name + '.title.text',
                 placeholder: fullLayout._dfltTitle.x,
                 attributes: {
                     x: axisOpts._offset + axisOpts._length / 2,

src/plots/polar/polar.js

@@ -589,7 +589,7 @@ proto.updateRadialAxisTitle = function(fullLayout, polarLayout, _angle) {
 
     _this.layers['radial-axis-title'] = Titles.draw(gd, titleClass, {
         propContainer: radialLayout,
-        propName: _this.id + '.radialaxis.title',
+        propName: _this.id + '.radialaxis.title.text',
         placeholder: _(gd, 'Click to enter radial axis title'),
         attributes: {
             x: x,

src/plots/ternary/ternary.js

@@ -375,7 +375,7 @@ proto.drawAxes = function(doTitles) {
 
         layers['a-title'] = Titles.draw(gd, 'a' + titlesuffix, {
             propContainer: aaxis,
-            propName: _this.id + '.aaxis.title',
+            propName: _this.id + '.aaxis.title.text',
             placeholder: _(gd, 'Click to enter Component A title'),
             attributes: {
                 x: _this.x0 + _this.w / 2,
@@ -385,7 +385,7 @@ proto.drawAxes = function(doTitles) {
         });
         layers['b-title'] = Titles.draw(gd, 'b' + titlesuffix, {
             propContainer: baxis,
-            propName: _this.id + '.baxis.title',
+            propName: _this.id + '.baxis.title.text',
             placeholder: _(gd, 'Click to enter Component B title'),
             attributes: {
                 x: _this.x0 - bpad,
@@ -395,7 +395,7 @@ proto.drawAxes = function(doTitles) {
         });
         layers['c-title'] = Titles.draw(gd, 'c' + titlesuffix, {
             propContainer: caxis,
-            propName: _this.id + '.caxis.title',
+            propName: _this.id + '.caxis.title.text',
             placeholder: _(gd, 'Click to enter Component C title'),
             attributes: {
                 x: _this.x0 + _this.w + bpad,

test/jasmine/tests/transition_test.js

@@ -648,7 +648,7 @@ describe('Plotly.react transitions:', function() {
             layout.xaxis.range = [-1, 1];
             return Plotly.react(gd, data, layout);
         })
-        .then(delay(50))
+        .then(delay(100))
         .then(function() {
             assertSpies('both trace and layout transitions', [
                 [Plots, 'transitionFromReact', 1],