Skip to content

Commit dd48914

Browse files
Add missing check
1 parent 54d8b58 commit dd48914

File tree

2 files changed

+21
-19
lines changed

2 files changed

+21
-19
lines changed

src/components/rangeslider/defaults.js

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -45,26 +45,28 @@ module.exports = function handleDefaults(layoutIn, layoutOut, axName) {
4545
coerce('range');
4646

4747
var subplots = layoutOut._subplots;
48-
var yIds = subplots.yaxis;
49-
var yNames = Lib.simpleMap(yIds, axisIds.id2name);
50-
for(var i = 0; i < yNames.length; i++) {
51-
var yName = yNames[i];
52-
if(!containerIn[yName]) {
53-
containerIn[yName] = {};
54-
}
55-
if(!containerOut[yName]) {
56-
containerOut[yName] = {};
57-
}
48+
if(subplots) {
49+
var yIds = subplots.yaxis;
50+
var yNames = Lib.simpleMap(yIds, axisIds.id2name);
51+
for(var i = 0; i < yNames.length; i++) {
52+
var yName = yNames[i];
53+
if(!containerIn[yName]) {
54+
containerIn[yName] = {};
55+
}
56+
if(!containerOut[yName]) {
57+
containerOut[yName] = {};
58+
}
5859

59-
if(containerIn[yName].range && layoutOut[yName].isValidRange(containerIn[yName].range)) {
60-
coerceRange(yName, 'rangemode', 'fixed');
61-
} else {
62-
coerceRange(yName, 'rangemode', 'auto');
63-
}
60+
if(containerIn[yName].range && layoutOut[yName].isValidRange(containerIn[yName].range)) {
61+
coerceRange(yName, 'rangemode', 'fixed');
62+
} else {
63+
coerceRange(yName, 'rangemode', 'auto');
64+
}
6465

65-
layoutOut[yName].cleanRange('rangeslider.' + yName + '.range');
66-
coerceRange(yName, 'range', layoutOut[yName].rangeslider[yName].range.slice());
67-
delete layoutOut[yName].rangeslider;
66+
layoutOut[yName].cleanRange('rangeslider.' + yName + '.range');
67+
coerceRange(yName, 'range', layoutOut[yName].rangeslider[yName].range.slice());
68+
delete layoutOut[yName].rangeslider;
69+
}
6870
}
6971

7072
// to map back range slider (auto) range

src/plots/cartesian/axes.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ axes.doAutoRange = function(ax) {
370370

371371
if(ax.rangeslider) {
372372
var anchorAxis = ax._anchorAxis;
373-
if(ax.rangeslider[anchorAxis._name].rangemode === 'auto') {
373+
if(ax.rangeslider[anchorAxis._name] && ax.rangeslider[anchorAxis._name].rangemode === 'auto') {
374374
hasDeps = (anchorAxis._min && anchorAxis._max && anchorAxis._min.length && anchorAxis._max.length);
375375
ax.rangeslider[anchorAxis._name].range = hasDeps ? axes.getAutoRange(anchorAxis) : anchorAxis.range.slice();
376376
axIn = ax._input;

0 commit comments

Comments
 (0)