Skip to content

Commit e4bc91e

Browse files
committed
treemap drop leaf.opacity
1 parent e9c0202 commit e4bc91e

File tree

11 files changed

+1
-114
lines changed

11 files changed

+1
-114
lines changed

src/traces/treemap/attributes.js

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -161,21 +161,6 @@ module.exports = {
161161
})
162162
),
163163

164-
leaf: {
165-
opacity: {
166-
valType: 'number',
167-
editType: 'style',
168-
role: 'style',
169-
min: 0,
170-
max: 1,
171-
dflt: 1,
172-
description: [
173-
'Sets the opacity of the leaves.'
174-
].join(' ')
175-
},
176-
editType: 'plot'
177-
},
178-
179164
pathbar: {
180165
visible: {
181166
valType: 'boolean',

src/traces/treemap/defaults.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
8686
colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: 'marker.', cLetter: 'c'});
8787
}
8888
coerce('marker.opacity', withColorscale ? 1 : 0.7);
89-
coerce('leaf.opacity');
9089

9190
traceOut._hovered = {
9291
marker: {

src/traces/treemap/style.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
var d3 = require('d3');
1212
var Color = require('../../components/color');
1313
var Lib = require('../../lib');
14-
var helpers = require('../sunburst/helpers');
1514

1615
function style(gd) {
1716
gd._fullLayout._treemaplayer.selectAll('.trace').each(function(cd) {
@@ -43,7 +42,7 @@ function styleOne(s, pt, trace, opts) {
4342
} else {
4443
lineColor = Lib.castOption(trace, ptNumber, 'marker.line.color') || Color.defaultLine;
4544
lineWidth = Lib.castOption(trace, ptNumber, 'marker.line.width') || 0;
46-
opacity = helpers.isLeaf(pt) ? trace.leaf.opacity : Math.pow(trace.marker.opacity, pt.height);
45+
opacity = Math.pow(trace.marker.opacity, pt.height);
4746
}
4847

4948
s.style('stroke-width', lineWidth)
-214 Bytes
Loading
-3.57 KB
Loading
-2 Bytes
Loading
425 Bytes
Loading

test/image/mocks/treemap_packings.json

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,6 @@
7272
"Uniform",
7373
"Uniform"
7474
],
75-
"leaf": {
76-
"opacity": 0.85
77-
},
7875
"marker": {
7976
"colorscale": "Blackbody",
8077
"reversescale": true
@@ -162,9 +159,6 @@
162159
"Uniform",
163160
"Uniform"
164161
],
165-
"leaf": {
166-
"opacity": 0.85
167-
},
168162
"marker": {
169163
"colorscale": "Blackbody",
170164
"reversescale": true
@@ -252,9 +246,6 @@
252246
"Uniform",
253247
"Uniform"
254248
],
255-
"leaf": {
256-
"opacity": 0.85
257-
},
258249
"marker": {
259250
"colorscale": "Blackbody",
260251
"reversescale": true
@@ -342,9 +333,6 @@
342333
"Uniform",
343334
"Uniform"
344335
],
345-
"leaf": {
346-
"opacity": 0.85
347-
},
348336
"marker": {
349337
"colorscale": "Blackbody",
350338
"reversescale": true
@@ -432,9 +420,6 @@
432420
"Uniform",
433421
"Uniform"
434422
],
435-
"leaf": {
436-
"opacity": 0.85
437-
},
438423
"marker": {
439424
"colorscale": "Blackbody",
440425
"reversescale": true
@@ -522,9 +507,6 @@
522507
"Uniform",
523508
"Uniform"
524509
],
525-
"leaf": {
526-
"opacity": 0.85
527-
},
528510
"marker": {
529511
"colorscale": "Blackbody",
530512
"reversescale": true

test/image/mocks/treemap_pad_transpose.json

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@
1313
"packing": "dice-slice",
1414
"pad": 0
1515
},
16-
"leaf": {
17-
"opacity": 0.7
18-
},
1916
"marker": {
2017
"pad": {
2118
"t": 16,
@@ -105,9 +102,6 @@
105102
"flip": "y",
106103
"pad": 0
107104
},
108-
"leaf": {
109-
"opacity": 0.7
110-
},
111105
"marker": {
112106
"pad": {
113107
"t": 16,
@@ -197,9 +191,6 @@
197191
"flip": "x",
198192
"pad": 0
199193
},
200-
"leaf": {
201-
"opacity": 0.7
202-
},
203194
"marker": {
204195
"pad": {
205196
"t": 16,
@@ -289,9 +280,6 @@
289280
"flip": "x+y",
290281
"pad": 0
291282
},
292-
"leaf": {
293-
"opacity": 0.7
294-
},
295283
"marker": {
296284
"pad": {
297285
"t": 16,

test/image/mocks/treemap_transpose_nopad.json

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616
"squarifyratio": 1,
1717
"pad": 0
1818
},
19-
"leaf": {
20-
"opacity": 0.5
21-
},
2219
"marker": {
2320
"pad": {
2421
"t": 0,
@@ -110,9 +107,6 @@
110107
"squarifyratio": 1.618034,
111108
"pad": 0
112109
},
113-
"leaf": {
114-
"opacity": 0.5
115-
},
116110
"marker": {
117111
"pad": {
118112
"t": 0,
@@ -204,9 +198,6 @@
204198
"squarifyratio": 1,
205199
"pad": 0
206200
},
207-
"leaf": {
208-
"opacity": 0.5
209-
},
210201
"marker": {
211202
"pad": {
212203
"t": 0,
@@ -298,9 +289,6 @@
298289
"squarifyratio": 1.618034,
299290
"pad": 0
300291
},
301-
"leaf": {
302-
"opacity": 0.5
303-
},
304292
"marker": {
305293
"pad": {
306294
"t": 0,

0 commit comments

Comments
 (0)