Skip to content

Commit ef081bf

Browse files
committed
remove require js fixture - for now
1 parent 198d46d commit ef081bf

File tree

5 files changed

+0
-46
lines changed

5 files changed

+0
-46
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,6 @@
170170
"prepend-file": "^2.0.0",
171171
"prettysize": "^2.0.0",
172172
"read-last-lines": "^1.7.2",
173-
"requirejs": "^2.3.6",
174173
"run-series": "^1.1.9",
175174
"through2": "^4.0.2",
176175
"true-case-path": "^2.2.1",

tasks/pretest.js

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ var common = require('./util/common');
66
// main
77
makeCredentialsFile();
88
makeTestImageFolders();
9-
makeRequireJSFixture();
109

1110
// Create a credentials json file,
1211
// to be required in jasmine test suites and test dashboard
@@ -32,20 +31,6 @@ function makeTestImageFolders() {
3231
makeOne(constants.pathToTestImagesDiff, 'test image diff folder');
3332
}
3433

35-
// Make script file that define plotly in a RequireJS context
36-
function makeRequireJSFixture() {
37-
var bundle = fs.readFileSync(constants.pathToPlotlyDistMin, 'utf-8');
38-
39-
var index = [
40-
'define(\'plotly\', function(require, exports, module) {',
41-
bundle,
42-
'});'
43-
].join('');
44-
45-
common.writeFile(constants.pathToRequireJSFixture, index);
46-
logger('make build/requirejs_fixture.js');
47-
}
48-
4934
function logger(task) {
5035
console.log('ok ' + task);
5136
}

tasks/util/constants.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@ module.exports = {
8585

8686
pathToJasmineTests: path.join(pathToRoot, 'test/jasmine/tests'),
8787
pathToJasmineBundleTests: path.join(pathToRoot, 'test/jasmine/bundle_tests'),
88-
pathToRequireJS: path.join(pathToRoot, 'node_modules', 'requirejs', 'require.js'),
89-
pathToRequireJSFixture: path.join(pathToBuild, 'requirejs_fixture.js'),
9088

9189
// this mapbox access token is 'public', no need to hide it
9290
// more info: https://www.mapbox.com/help/define-access-token/

test/jasmine/bundle_tests/requirejs_test.js

Lines changed: 0 additions & 19 deletions
This file was deleted.

test/jasmine/karma.conf.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -306,15 +306,6 @@ func.defaultConfig.preprocessors[pathToCustomMatchers] = ['browserify'];
306306

307307
if(isBundleTest) {
308308
switch(basename(testFileGlob)) {
309-
case 'requirejs':
310-
// browserified custom_matchers doesn't work with this route
311-
// so clear them out of the files and preprocessors
312-
func.defaultConfig.files = [
313-
constants.pathToRequireJS,
314-
constants.pathToRequireJSFixture
315-
];
316-
delete func.defaultConfig.preprocessors[pathToCustomMatchers];
317-
break;
318309
case 'minified_bundle':
319310
func.defaultConfig.files.push(constants.pathToPlotlyDistMin);
320311
func.defaultConfig.preprocessors[testFileGlob] = ['browserify'];

0 commit comments

Comments
 (0)