Skip to content

Commit f3ae9e2

Browse files
committed
Use Lib.isArrayOrTypedArray in quiver/calc.js as well
1 parent d116c64 commit f3ae9e2

File tree

9 files changed

+2
-19
lines changed

9 files changed

+2
-19
lines changed

src/traces/quiver/attributes.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,5 +254,3 @@ attrs.hovertemplate = extendFlat({}, hovertemplateAttrs({}, {
254254
}));
255255

256256
module.exports = attrs;
257-
258-

src/traces/quiver/calc.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ module.exports = function calc(gd, trace) {
2929
var normMax = -Infinity;
3030
var cMin = Infinity;
3131
var cMax = -Infinity;
32-
var hasC = Array.isArray(trace.c);
32+
var hasC = Lib.isArrayOrTypedArray(trace.c);
3333

3434
for(var i = 0; i < len; i++) {
3535
var cdi = cd[i] = { i: i };
@@ -75,5 +75,3 @@ module.exports = function calc(gd, trace) {
7575

7676
return cd;
7777
};
78-
79-

src/traces/quiver/event_data.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,3 @@ module.exports = function eventData(out, pt, trace, cd, pointNumber) {
88

99
return out;
1010
};
11-
12-

src/traces/quiver/format_labels.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,3 @@ module.exports = function formatLabels(cdi, trace, fullLayout) {
2323

2424
return labels;
2525
};
26-

src/traces/quiver/hover.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,5 +62,3 @@ module.exports = function hoverPoints(pointData, xval, yval, hovermode) {
6262

6363
return [pointData];
6464
};
65-
66-

src/traces/quiver/index.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,3 @@ module.exports = {
3030
].join(' ')
3131
}
3232
};
33-
34-

src/traces/quiver/plot.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ function plotOne(gd, idx, plotinfo, cdscatter, cdscatterAll, element, transition
191191
lineSegments.style('stroke', function(cdi) {
192192
var cArr = trace.c;
193193
var value;
194-
if (Array.isArray(cArr) && cArr.length > cdi.i && isFinite(cArr[cdi.i])) {
194+
if (Lib.isArrayOrTypedArray(cArr) && cArr.length > cdi.i && isFinite(cArr[cdi.i])) {
195195
value = cArr[cdi.i];
196196
} else {
197197
var uVal = (trace.u && trace.u[cdi.i]) || 0;
@@ -212,5 +212,3 @@ function plotOne(gd, idx, plotinfo, cdscatter, cdscatterAll, element, transition
212212
.style('opacity', 1);
213213
}
214214
}
215-
216-

src/traces/quiver/select_points.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,5 +37,3 @@ module.exports = function selectPoints(searchInfo, selectionTester) {
3737

3838
return selection;
3939
};
40-
41-

src/traces/quiver/style.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,3 @@ module.exports = function style(gd, calcTrace) {
1414
s.selectAll('path.js-line')
1515
.call(Drawing.lineGroupStyle, trace.line || {});
1616
};
17-
18-

0 commit comments

Comments
 (0)