Skip to content

Commit f963280

Browse files
committed
correct coerce function and remove unused code
1 parent a631894 commit f963280

File tree

2 files changed

+1
-27
lines changed

2 files changed

+1
-27
lines changed

src/traces/bar/helpers.js

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -16,32 +16,6 @@ exports.coerceString = function(attributeDefinition, value, defaultValue) {
1616
attributeDefinition.dflt;
1717
};
1818

19-
exports.coerceInteger = function(attributeDefinition, value, defaultValue) {
20-
if(isNumeric(value)) {
21-
value = +value;
22-
23-
value = Math.round(value);
24-
25-
var min = attributeDefinition.min;
26-
var max = attributeDefinition.max;
27-
var isOutOfBounds = (min !== undefined && value < min) ||
28-
(max !== undefined && value > max);
29-
30-
if(!isOutOfBounds) return value;
31-
}
32-
33-
if(
34-
attributeDefinition.extras &&
35-
attributeDefinition.extras.indexOf(value) !== -1
36-
) {
37-
return value;
38-
}
39-
40-
return (defaultValue !== undefined) ?
41-
defaultValue :
42-
attributeDefinition.dflt;
43-
};
44-
4519
exports.coerceNumber = function(attributeDefinition, value, defaultValue) {
4620
if(isNumeric(value)) {
4721
value = +value;

src/traces/bar/style.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ function getFontValue(attributeDefinition, attributeValue, index, defaultValue)
157157
attributeDefinition.size, sizeValue, defaultValue.size),
158158
color: helpers.coerceColor(
159159
attributeDefinition.color, colorValue, defaultValue.color),
160-
weight: helpers.coerceInteger(
160+
weight: helpers.coerceString(
161161
attributeDefinition.weight, weightValue, defaultValue.weight),
162162
style: helpers.coerceString(
163163
attributeDefinition.style, styleValue, defaultValue.style),

0 commit comments

Comments
 (0)