set auto shadow for sankey, parcats and parcoords that has text-shadow before

Author: archmoj

src/lib/coerce.js

@@ -469,9 +469,15 @@ exports.coerceFont = function(coerce, attr, dfltObj, opts) {
     out.weight = coerce(attr + '.weight', dfltObj.weight);
     out.style = coerce(attr + '.style', dfltObj.style);
     if(!opts.noFontVariant) out.variant = coerce(attr + '.variant', dfltObj.variant);
-    if(!opts.noFontShadow) out.shadow = coerce(attr + '.shadow', dfltObj.shadow);
     if(!opts.noFontStriding) out.striding = coerce(attr + '.striding', dfltObj.striding);
     if(!opts.noFontCapitalize) out.capitalize = coerce(attr + '.capitalize', dfltObj.capitalize);
+    if(!opts.noFontShadow) {
+        var dfltShadow = dfltObj.shadow;
+        if(dfltShadow === 'none' && opts.autoShadowDflt) {
+            dfltShadow = 'auto';
+        }
+        out.shadow = coerce(attr + '.shadow', dfltShadow);
+    }
 
     return out;
 };

src/plots/font_attributes.js

@@ -114,7 +114,7 @@ module.exports = function(opts) {
         shadow: opts.noFontShadow ? undefined : {
             editType: editType,
             valType: 'string',
-            dflt: 'none',
+            dflt: opts.autoShadowDflt ? 'auto' : 'none',
             extras: ['auto'],
             description: [
                 'Sets the shape and color of the shadow behind text.',

src/traces/parcats/attributes.js

@@ -105,6 +105,7 @@ module.exports = {
     }),
 
     tickfont: fontAttrs({
+        autoShadowDflt: true,
         editType: 'calc',
         description: 'Sets the font for the `category` labels.'
     }),

src/traces/parcats/defaults.js

@@ -121,5 +121,5 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
         color: layout.font.color
     };
 
-    Lib.coerceFont(coerce, 'tickfont', categoryfontDefault);
+    Lib.coerceFont(coerce, 'tickfont', categoryfontDefault, { autoShadowDflt: true });
 };

src/traces/parcats/parcats.js

@@ -225,8 +225,6 @@ function performPlot(parcatsModels, graphDiv, layout, svg) {
         .attr('class', 'catlabel')
         .attr('pointer-events', 'none');
 
-    var paperColor = graphDiv._fullLayout.paper_bgcolor;
-
     // Update category label
     categorySelection.select('text.catlabel')
         .attr('text-anchor',
@@ -240,8 +238,6 @@ function performPlot(parcatsModels, graphDiv, layout, svg) {
                 }
             })
         .attr('alignment-baseline', 'middle')
-
-        .style('text-shadow', svgTextUtils.makeTextShadow(paperColor))
         .style('fill', 'rgb(0, 0, 0)')
         .attr('x',
             function(d) {

src/traces/parcoords/attributes.js

@@ -42,6 +42,7 @@ module.exports = {
         description: 'Sets the font for the `dimension` labels.'
     }),
     tickfont: fontAttrs({
+        autoShadowDflt: true,
         editType: 'plot',
         description: 'Sets the font for the `dimension` tick values.'
     }),

src/traces/parcoords/defaults.js

@@ -108,7 +108,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     };
 
     Lib.coerceFont(coerce, 'labelfont', fontDflt);
-    Lib.coerceFont(coerce, 'tickfont', fontDflt);
+    Lib.coerceFont(coerce, 'tickfont', fontDflt, { autoShadowDflt: true });
     Lib.coerceFont(coerce, 'rangefont', fontDflt);
 
     coerce('labelangle');

src/traces/parcoords/parcoords.js

@@ -661,7 +661,6 @@ module.exports = function parcoords(gd, cdModule, layout, callbacks) {
         .attr('stroke-width', '1px');
 
     axis.selectAll('text')
-        .style('text-shadow', svgTextUtils.makeTextShadow(paperColor))
         .style('cursor', 'default');
 
     var axisHeading = axisOverlays.selectAll('.' + c.cn.axisHeading)

src/traces/sankey/attributes.js

@@ -64,6 +64,7 @@ var attrs = module.exports = overrideAll({
     },
 
     textfont: fontAttrs({
+        autoShadowDflt: true,
         description: 'Sets the font for node labels'
     }),
 

src/traces/sankey/defaults.js

@@ -106,7 +106,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     }
     coerce('arrangement', dfltArrangement);
 
-    Lib.coerceFont(coerce, 'textfont', Lib.extendFlat({}, layout.font));
+    var fontDflt = Lib.extendFlat({}, layout.font);
+    Lib.coerceFont(coerce, 'textfont', fontDflt, { autoShadowDflt: true });
 
     // disable 1D transforms - arrays here are 1D but their lengths/meanings
     // don't match, between nodes and links