Skip to content

Commit b4cd36c

Browse files
committed
Make js uncommitted files check its own job
1 parent f51b3dc commit b4cd36c

File tree

1 file changed

+27
-24
lines changed

1 file changed

+27
-24
lines changed

.circleci/config.yml

Lines changed: 27 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -14,32 +14,11 @@ executors:
1414
- image: cimg/python:<<parameters.python_version>>-browsers
1515

1616
commands:
17-
check-js-build:
18-
description: Fail if JupyterLab extension build artifacts are out of date
19-
steps:
20-
- run:
21-
name: Build JupyterLab extension
22-
command: |
23-
echo "Building JupyterLab extension..."
24-
curl -LsSf https://astral.sh/uv/install.sh | sh
25-
uv venv
26-
source .venv/bin/activate
27-
uv pip install jupyter
28-
cd js
29-
npm ci
30-
npm run build
31-
- run:
32-
name: Check JupyterLab build artifacts
33-
command: |
34-
echo "Checking for uncommitted changes in plotly/labextension/..."
35-
git diff --exit-code plotly/labextension/ || (echo "Error: JupyterLab build artifacts out of date. Run 'npm run build' in js/ and commit the results." && exit 1)
36-
3717
test_core:
3818
steps:
3919
- checkout
4020
- browser-tools/install-chrome
4121
- browser-tools/install-chromedriver
42-
- check-js-build
4322
- run:
4423
name: Install dependencies
4524
command: |
@@ -71,7 +50,6 @@ commands:
7150
- checkout
7251
- browser-tools/install-chrome
7352
- browser-tools/install-chromedriver
74-
- check-js-build
7553
- run:
7654
name: Install dependencies
7755
command: |
@@ -185,6 +163,31 @@ jobs:
185163
pandas_version: <<parameters.pandas_version>>
186164
numpy_version: <<parameters.numpy_version>>
187165

166+
check-js-build:
167+
docker:
168+
- image: cimg/python:3.12-node
169+
environment:
170+
LANG: en_US.UTF-8
171+
resource_class: large
172+
173+
steps:
174+
- checkout
175+
- run:
176+
name: Install dependencies
177+
command: |
178+
curl -LsSf https://astral.sh/uv/install.sh | sh
179+
uv venv
180+
source .venv/bin/activate
181+
uv pip install -e .
182+
cd js
183+
npm ci
184+
npm run build
185+
- run:
186+
name: Check JupyterLab build artifacts
187+
command: |
188+
echo "Checking for uncommitted changes in plotly/labextension/..."
189+
git diff --exit-code plotly/labextension/ || (echo "Error: JupyterLab build artifacts out of date. Run 'npm run build' in js/ and commit the results." && exit 1)
190+
188191
# Percy
189192
python_311_percy:
190193
docker:
@@ -320,8 +323,6 @@ jobs:
320323
- checkout
321324
- browser-tools/install-chrome
322325
- browser-tools/install-chromedriver
323-
- check-js-build
324-
325326
- run:
326327
name: Install dependencies
327328
command: |
@@ -456,3 +457,5 @@ workflows:
456457
numpy_version: "1.26.4"
457458
- python_311_percy
458459
- build-doc
460+
- check-js-build:
461+
name: "Check for uncommitted changes in plotly/labextension"

0 commit comments

Comments
 (0)