break json conversion to a testable separate function

Author: chriddyp

plotly/grid_objs/grid_objs.py

@@ -73,10 +73,20 @@ def _validate_insertion(self, column):
             err = exceptions.NON_UNIQUE_COLUMN_MESSAGE.format(column.name)
             raise exceptions.InputError(err)
 
+    def _to_plotly_grid_json(self):
+        grid_json = {'cols': {}}
+        for column_index, column in enumerate(self):
+            grid_json['cols'][column.name] = {
+                'data': column.data,
+                'order': column_index
+            }
+        return grid_json
+
     def get_column(self, column_name):
         """ Return the first column with name `column_name`.
         If no column with `column_name` exists in this grid, return None.
         """
         for column in self._columns:
             if column.name == column_name:
                 return column
+

plotly/plotly/plotly.py

@@ -695,16 +695,10 @@ def upload(cls, grid, filename, world_readable=True, auto_open=True, meta=None):
             file_ops.mkdirs(parent_path)
 
         # transmorgify grid object into plotly's format
-        grid_json = {'cols': {}}
+        grid_json = grid._to_plotly_grid_json()
         if meta is not None:
             grid_json['metadata'] = meta
 
-        for column_index, column in enumerate(grid):
-            grid_json['cols'][column.name] = {
-                'data': column.data,
-                'order': column_index
-            }
-
         payload = {
             'filename': filename,
             'data': json.dumps(grid_json),